Subject: Re: [PATCH] clocksource_cyc2ns: avoid overflowing 64 bits
To: John Stultz <john.stultz@linaro.org>
References: <1479315472-5245-1-git-send-email-cmetcalf@mellanox.com>
 <CALAqxLVK31SNp6Z+6GL1YHzxY44-ghG3C6b0kqi3pyOX63-_tA@mail.gmail.com>
 <bf36c76f-b26f-8d17-b951-f6b919845172@mellanox.com>
 <CALAqxLXV39Zt0Qp7fnwfR_PEnk4QVEYBfZ8e7k_fUtbT=VgKEw@mail.gmail.com>
 <295ab33e-45da-af64-6716-c8f387a0cb20@mellanox.com>
 <CALAqxLVTUkx4x6z=AmqWruhfX9L6R_MVZd+_uiGOoQU-fV-K-A@mail.gmail.com>
CC: Thomas Gleixner <tglx@linutronix.de>, Salman Qazi <sqazi@google.com>,
        Paul Turner <pjt@google.com>, Tony Lindgren <tony@atomide.com>,
        Steven Miao <realmz6@gmail.com>, lkml <linux-kernel@vger.kernel.org>
From: Chris Metcalf <cmetcalf@mellanox.com>
Message-ID: <c7b95165-f484-dd33-d9ca-03af725e1d1f@mellanox.com>
Date: Wed, 16 Nov 2016 15:30:10 -0500
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <CALAqxLVTUkx4x6z=AmqWruhfX9L6R_MVZd+_uiGOoQU-fV-K-A@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2016 20:30:19.9104 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2768
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2290
Lines: 48

On 11/16/2016 3:00 PM, John Stultz wrote:
> On Wed, Nov 16, 2016 at 11:56 AM, Chris Metcalf <cmetcalf@mellanox.com> wrote:
>> On 11/16/2016 2:45 PM, John Stultz wrote:
>>> On Wed, Nov 16, 2016 at 11:30 AM, Chris Metcalf <cmetcalf@mellanox.com>
>>> wrote:
>>>> diff --git a/include/linux/clocksource.h b/include/linux/clocksource.h
>>>> index 08398182f56e..5444429884b8 100644
>>>> --- a/include/linux/clocksource.h
>>>> +++ b/include/linux/clocksource.h
>>>> @@ -171,6 +171,10 @@ static inline u32 clocksource_hz2mult(u32 hz, u32
>>>> shift_constant)
>>>>     *
>>>>     * Converts cycles to nanoseconds, using the given mult and shift.
>>>>     *
>>>> + * The code is optimized for performance and not intended to work
>>>> + * with absolute clocksource cycles, as it will easily overflow,
>>>> + * but just intended for relative (delta) clocksource cycles.
>>>> + *
>>>>     * XXX - This could use some mult_lxl_ll() asm optimization
>>> Just as a heads up, it seems your working against an older kernel, as
>>> this didn't apply. Its simple enough to fix up, so I'll do so, but in
>>> the future, please submit patches against something close to Linus
>>> HEAD.
>>
>> Oops, sorry; it wasn't version skew (I'm at v4.9-rc4) but whitespace damage.
>> I assumed if I just pasted the patch into Thunderbird it would work, since
>> it had
>> no tabs.  But bizarrely, if I look at the patch in the mailer, it shows a
>> two-space
>> prefix, but when I save the email to a file, it has a three-space prefix.
>> WTF?
> Yea. Not many mailers can be trusted with sending patches. I'd
> recommend git-send-email. :)

Yes, indeed.  That is what I always do normally.  But since I was
already part way through an email written interactively in my mailer,
I figured I'd be lazy and paste it in.  Lesson learned...

That said, it is annoyingly difficult to pick up an in-progress email
and convert it into something you can edit in, say, Emacs.  You end up
having to cut and paste the "To:" and "Cc:" and "Subject:" information
out of your mailer's helpful GUI and into Emacs in the standard RFC822
way that git send-email understands.  I'm not sure there's a better
way, but at least I feel better now that I've complained about it :-)

-- 
Chris Metcalf, Mellanox Technologies
http://www.mellanox.com