Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754150AbcKPWAc (ORCPT ); Wed, 16 Nov 2016 17:00:32 -0500 Received: from mail-it0-f66.google.com ([209.85.214.66]:35788 "EHLO mail-it0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752742AbcKPWAa (ORCPT ); Wed, 16 Nov 2016 17:00:30 -0500 MIME-Version: 1.0 X-Originating-IP: [217.173.44.24] In-Reply-To: References: <1477380887-21333-1-git-send-email-mszeredi@redhat.com> <1477380887-21333-4-git-send-email-mszeredi@redhat.com> <20161025115748.ydhkkp5cfcdnjzwn@home.ouaza.com> <20161107110319.7goz3ym3e6fu5lag@home.ouaza.com> <20161107134215.2v5leafss2mamim5@home.ouaza.com> From: Miklos Szeredi Date: Wed, 16 Nov 2016 23:00:28 +0100 Message-ID: Subject: Re: [PATCH 3/3] ovl: redirect on rename-dir To: Amir Goldstein Cc: Raphael Hertzog , Konstantin Khlebnikov , Miklos Szeredi , "linux-unionfs@vger.kernel.org" , Guillem Jover , linux-fsdevel , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 799 Lines: 23 On Mon, Nov 14, 2016 at 5:25 PM, Amir Goldstein wrote: > On Sun, Nov 13, 2016 at 12:00 PM, Amir Goldstein wrote: >> Looks goods, except for the case of change from relative to absolute >> redirect of the victim dentry. IIUC, ovl_set_redirect() will return immediately >> because ovl_dentry_is_redirect() and will not get to setting the absolute >> redirect. >> > > I added some more tests to catch this problem at: > https://github.com/amir73il/unionmount-testsuite.git #ovl_rename_dir Thanks for testing. Force pushed updated version to the usual place: git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git #redirect This also has the xattr feature thing replaced with mount option, module param and kernel config option. Thanks, Miklos