Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941326AbcKPWtG (ORCPT ); Wed, 16 Nov 2016 17:49:06 -0500 Received: from mail.kernel.org ([198.145.29.136]:60886 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753975AbcKPWtD (ORCPT ); Wed, 16 Nov 2016 17:49:03 -0500 Date: Wed, 16 Nov 2016 16:48:58 -0600 From: Bjorn Helgaas To: Dexuan Cui Cc: Bjorn Helgaas , "linux-pci@vger.kernel.org" , "devel@linuxdriverproject.org" , "gregkh@linuxfoundation.org" , KY Srinivasan , Haiyang Zhang , Stephen Hemminger , Jake Oshins , Hadden Hoppert , Vitaly Kuznetsov , "jasowang@redhat.com" , "apw@canonical.com" , "olaf@aepfle.de" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 0/3] PCI: hv: clean-up and 2 fixes to the hot-remove case Message-ID: <20161116224858.GC16042@bhelgaas-glaptop.roam.corp.google.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1251 Lines: 28 On Thu, Nov 10, 2016 at 07:16:22AM +0000, Dexuan Cui wrote: > PATCH 1 is just a clean-up. There should be no functional change. > > PATCH 2 and 3 are for device hot-remove case. > Currently the driver will stop working or even cause panic, if we do > hot add/remove quickly a few times. With the 2 patches, everything works > reliably in my tests now. > > There can be still a potential issue with hot-remove when we unload > the driver at the same time. That would require more work of proper > synchronization among the 3 paths: the .probe/.remove, the channel callback, > and the offloaded hv_pci_devices_present()/hv_eject_device_work(). > > But for now, PATCH 2 and 3 do improve the situation a lot. > > Dexuan Cui (3): > PCI: hv: use the correct buffer size in new_pcichild_device() > PCI: hv: fix hv_pci_remove() for hot-remove > PCI: hv: delete the device earlier from hbus->children for hot-remove > > drivers/pci/host/pci-hyperv.c | 67 ++++++++++++++++++++++++++----------------- > 1 file changed, 40 insertions(+), 27 deletions(-) I applied all three of these to pci/host-hv for v4.10, thanks! Jake, I converted your "looks good to me" to Reviewed-by tags. K. Y., I added your acks on 2 & 3. If you acked 1, I missed it.