Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941515AbcKPWwO (ORCPT ); Wed, 16 Nov 2016 17:52:14 -0500 Received: from balrog.mythic-beasts.com ([93.93.130.6]:58053 "EHLO balrog.mythic-beasts.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S941362AbcKPWwN (ORCPT ); Wed, 16 Nov 2016 17:52:13 -0500 From: Luis Henriques To: David Woodhouse , Brian Norris , Boris Brezillon , Marek Vasut , Richard Weinberger , Cyrille Pitchen Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Luis Henriques Subject: [PATCH] mtd: maps: add missing iounmap() in error path Date: Wed, 16 Nov 2016 22:50:16 +0000 Message-Id: <20161116225016.29958-1-henrix@camandro.org> X-BlackCat-Spam-Score: -28 X-Mythic-Debug: Threshold = On = Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 733 Lines: 26 This patch was triggered by the following Coccinelle error: ./drivers/mtd/maps/sc520cdp.c:246:3-9: \ ERROR: missing iounmap; ioremap on line 242 \ and execution via conditional on line 244 Signed-off-by: Luis Henriques --- drivers/mtd/maps/sc520cdp.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/mtd/maps/sc520cdp.c b/drivers/mtd/maps/sc520cdp.c index 093edd51bdc7..7a27ed345d0d 100644 --- a/drivers/mtd/maps/sc520cdp.c +++ b/drivers/mtd/maps/sc520cdp.c @@ -243,6 +243,10 @@ static int __init init_sc520cdp(void) if (!sc520cdp_map[i].virt) { printk("Failed to ioremap_nocache\n"); + if (i) { + while (--i) + iounmap(sc520cdp_map[i].virt); + } return -EIO; }