Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754255AbcKPXhy (ORCPT <rfc822;w@1wt.eu>);
        Wed, 16 Nov 2016 18:37:54 -0500
Received: from www.sr71.net ([198.145.64.142]:54568 "EHLO blackbird.sr71.net"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753617AbcKPXhx (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 16 Nov 2016 18:37:53 -0500
X-Greylist: delayed 320 seconds by postgrey-1.27 at vger.kernel.org; Wed, 16 Nov 2016 18:37:53 EST
Subject: Re: [RFC][PATCH] proc: mm: export PTE sizes directly in smaps
To: Dan Williams <dan.j.williams@intel.com>
References: <20161116190504.0B2BCCFC@viggo.jf.intel.com>
 <CAPcyv4j-uVyvgfELab9Jjy6yr3cgvSGnHDfsvNn1+-tzwp48eg@mail.gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Christoph Hellwig <hch@lst.de>,
        Andrew Morton <akpm@linux-foundation.org>,
        Anshuman Khandual <khandual@linux.vnet.ibm.com>
From: Dave Hansen <dave@sr71.net>
Message-ID: <661b0942-e66d-7f77-a6e0-510c1cc1b2b7@sr71.net>
Date: Wed, 16 Nov 2016 15:32:30 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <CAPcyv4j-uVyvgfELab9Jjy6yr3cgvSGnHDfsvNn1+-tzwp48eg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 359
Lines: 9

On 11/16/2016 11:39 AM, Dan Williams wrote:
>> > @@ -578,6 +582,7 @@ static void smaps_pmd_entry(pmd_t *pmd,
>> >                 /* pass */;
>> >         else
>> >                 VM_BUG_ON_PAGE(1, page);
>> > +       mss->rss_pmd += PAGE_SIZE;
> Should this be "HPAGE_PMD_SIZE"?

Yep, that's a typo.  I probably need to resend this and cc linux-mm@ anyway.