Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941169AbcKQACI (ORCPT ); Wed, 16 Nov 2016 19:02:08 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59564 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753269AbcKQACF (ORCPT ); Wed, 16 Nov 2016 19:02:05 -0500 Date: Wed, 16 Nov 2016 17:02:03 -0700 From: Alex Williamson To: Kirti Wankhede Cc: , , , , , , , , Subject: Re: [PATCH v14 11/22] vfio iommu: Add blocking notifier to notify DMA_UNMAP Message-ID: <20161116170203.7bc6ff86@t450s.home> In-Reply-To: <1479329194-10247-12-git-send-email-kwankhede@nvidia.com> References: <1479329194-10247-1-git-send-email-kwankhede@nvidia.com> <1479329194-10247-12-git-send-email-kwankhede@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 17 Nov 2016 00:02:05 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 540 Lines: 18 On Thu, 17 Nov 2016 02:16:23 +0530 Kirti Wankhede wrote: > @@ -1321,12 +1350,11 @@ static void vfio_iommu_unmap_unpin_reaccount(struct vfio_iommu *iommu) > > static void vfio_sanity_check_pfn_list(struct vfio_iommu *iommu) > { > - struct rb_node *n, *p; > + struct rb_node *n; > > n = rb_first(&iommu->dma_list); > for (; n; n = rb_next(n)) { > struct vfio_dma *dma; > - int unlocked = 0; > > dma = rb_entry(n, struct vfio_dma, node); > This chunk really should have been part of 10/22 as well.