MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Date: Wed, 16 Nov 2016 16:59:23 -0800
From: Stefan Agner <stefan@agner.ch>
To: dri-devel@lists.freedesktop.org
Cc: alison.wang@freescale.com, jianwei.wang.chn@gmail.com,
        linux-kernel@vger.kernel.org, daniel.vetter@ffwll.ch, meng.yi@nxp.com
Subject: Re: [PATCH 0/3] drm/fsl-dcu: fix driver remove/DRM unload
In-Reply-To: <20161020003221.2941-1-stefan@agner.ch>
References: <20161020003221.2941-1-stefan@agner.ch>
Message-ID: <19d9e2ee811aa1c02bf8a30069b4e27c@agner.ch>
User-Agent: Roundcube Webmail/1.1.3
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1411
Lines: 45

On 2016-10-19 17:32, Stefan Agner wrote:
> Hi All,
> 
> The first patch is a better alternative to the previously posted
> patch ("drm/fsl-dcu: only init fbdev if required") as suggested
> by Daniel.
> 
> The second and third are fix related issue uncovered during tests
> with bind/unbind:
> echo 40058000.dcu > /sys/bus/platform/drivers/fsl-dcu/unbind
> echo 40058000.dcu > /sys/bus/platform/drivers/fsl-dcu/bind
> 
> Especially the third patch I am not sure if that is a reasonable
> strategy to fix the issue. I did not saw another SoC DRM driver
> which is making use of drm_crtc_force_disable_all...
> 
> Also, when the X Server is running (with modesetting driver) I
> still get a warning:
> 
> WARNING: CPU: 0 PID: 452 at drivers/gpu/drm/drm_crtc.c:1154
> drm_mode_config_cleanup+0x210/0x220
> 
> The comment says it is the drivers fault, but as far as I can
> tell it is user space which does not free up this framebuffers.
> Is there something missing in my driver?
> 
> Any ideas?
> 
> --
> Stefan
> 
> Stefan Agner (3):
>   drm/fb_cma_helper: do not free fbdev if there is none
>   drm/fsl-dcu: unload driver before disabling clocks
>   drm/fsl-dcu: disable outputs before unloading driver
> 
>  drivers/gpu/drm/drm_fb_cma_helper.c       | 3 ++-
>  drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 3 ++-
>  2 files changed, 4 insertions(+), 2 deletions(-)


Applied 2/3 to my for-next branch.

--
Stefan