Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2992436AbcKQBee (ORCPT ); Wed, 16 Nov 2016 20:34:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50268 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932263AbcKQBeb (ORCPT ); Wed, 16 Nov 2016 20:34:31 -0500 Subject: Re: commit 0b5da8d: fuse: add support for SEEK_HOLE and SEEK_DATA in lseek To: Miklos Szeredi , linux-fsdevel , linux-kernel , fuse-devel References: <87d1hvmbjh.fsf@thinkpad.rath.org> From: Ravishankar N Message-ID: <2756c158-de24-01ac-8a52-4a9a332ff5e8@redhat.com> Date: Thu, 17 Nov 2016 07:04:26 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <87d1hvmbjh.fsf@thinkpad.rath.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 17 Nov 2016 01:34:31 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1098 Lines: 37 Hi Nikolaus, On 11/17/2016 01:39 AM, Nikolaus Rath wrote: > Hi Ravishankar, > > In commit 0b5da8d you added support for a new FUSE_LSEEK > operation. However, as far as I can tell the corresponding userspace > code never landed in libfuse. > > Do you have a corresponding patch for libfuse? No, unfortunately. I only used gluster to test what I wrote. > > Looking at the commit message, I assume this functionality was added > specifically for glusterfs which presumably does not use libfuse. You're right, gluster has its own code [1]. > But > even in that case it would be nice if you could Cc > fuse-devel@lists.sourceforge.net The discussion[2] actually did start on fuse-devel. > so that someone else can add support That would be great. > for this. This is important because AFAIR the libfuse documentation is > the only thing that comes close to an official documentation of the FUSE > API. > Best regards, Ravi [1] https://github.com/gluster/glusterfs/blob/master/xlators/mount/fuse/src/fuse-bridge.c [2] https://sourceforge.net/p/fuse/mailman/message/34227449/ > Best, > -Nikolaus >