Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754296AbcKQHV6 (ORCPT ); Thu, 17 Nov 2016 02:21:58 -0500 Received: from terminus.zytor.com ([198.137.202.10]:39864 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751139AbcKQHV4 (ORCPT ); Thu, 17 Nov 2016 02:21:56 -0500 Date: Wed, 16 Nov 2016 23:19:11 -0800 From: tip-bot for Arnd Bergmann Message-ID: Cc: peterz@infradead.org, jpoimboe@redhat.com, dvlasenk@redhat.com, bp@alien8.de, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, luto@kernel.org, tglx@linutronix.de, brgerst@gmail.com, hpa@zytor.com, mingo@kernel.org, arnd@arndb.de Reply-To: peterz@infradead.org, bp@alien8.de, dvlasenk@redhat.com, jpoimboe@redhat.com, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, luto@kernel.org, tglx@linutronix.de, brgerst@gmail.com, hpa@zytor.com, mingo@kernel.org, arnd@arndb.de In-Reply-To: <20161116141726.2013389-1-arnd@arndb.de> References: <20161116141726.2013389-1-arnd@arndb.de> To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/urgent] x86/boot: Avoid warning for zero-filling .bss Git-Commit-ID: 553bbc11aa6c1f9e0f529a06aeeca15fbe4a3985 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2117 Lines: 65 Commit-ID: 553bbc11aa6c1f9e0f529a06aeeca15fbe4a3985 Gitweb: http://git.kernel.org/tip/553bbc11aa6c1f9e0f529a06aeeca15fbe4a3985 Author: Arnd Bergmann AuthorDate: Wed, 16 Nov 2016 15:17:09 +0100 Committer: Ingo Molnar CommitDate: Thu, 17 Nov 2016 07:34:58 +0100 x86/boot: Avoid warning for zero-filling .bss The latest binutils are warning about a .fill directive with an explicit value in a .bss section: arch/x86/kernel/head_32.S: Assembler messages: arch/x86/kernel/head_32.S:677: Warning: ignoring fill value in section `.bss..page_aligned' arch/x86/kernel/head_32.S:679: Warning: ignoring fill value in section `.bss..page_aligned' This comes from the 'ENTRY()' macro padding the space between the symbols with 'nop' via: .align 4,0x90 Open-coding the .globl directive without the padding avoids that warning, as all the symbols are already page aligned. Signed-off-by: Arnd Bergmann Cc: Andy Lutomirski Cc: Borislav Petkov Cc: Brian Gerst Cc: Denys Vlasenko Cc: H. Peter Anvin Cc: Josh Poimboeuf Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Link: http://lkml.kernel.org/r/20161116141726.2013389-1-arnd@arndb.de Signed-off-by: Ingo Molnar --- arch/x86/kernel/head_32.S | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/arch/x86/kernel/head_32.S b/arch/x86/kernel/head_32.S index b6b2f02..2dabea4 100644 --- a/arch/x86/kernel/head_32.S +++ b/arch/x86/kernel/head_32.S @@ -665,14 +665,17 @@ __PAGE_ALIGNED_BSS initial_pg_pmd: .fill 1024*KPMDS,4,0 #else -ENTRY(initial_page_table) +.globl initial_page_table +initial_page_table: .fill 1024,4,0 #endif initial_pg_fixmap: .fill 1024,4,0 -ENTRY(empty_zero_page) +.globl empty_zero_page +empty_zero_page: .fill 4096,1,0 -ENTRY(swapper_pg_dir) +.globl swapper_pg_dir +swapper_pg_dir: .fill 1024,4,0 EXPORT_SYMBOL(empty_zero_page)