Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933095AbcKQJoI convert rfc822-to-8bit (ORCPT ); Thu, 17 Nov 2016 04:44:08 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57880 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750841AbcKQJoC (ORCPT ); Thu, 17 Nov 2016 04:44:02 -0500 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <147931984418.16460.6639993676886095760.stgit@warthog.procyon.org.uk> <147931988803.16460.18213104388363289832.stgit@warthog.procyon.org.uk> To: Mat Martineau Cc: dhowells@redhat.com, keyrings@vger.kernel.org, matthew.garrett@nebula.com, linux-security-module@vger.kernel.org, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/9] efi: Add EFI signature data types MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <26197.1479375840.1@warthog.procyon.org.uk> Content-Transfer-Encoding: 8BIT Date: Thu, 17 Nov 2016 09:44:00 +0000 Message-ID: <26198.1479375840@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Thu, 17 Nov 2016 09:44:02 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 294 Lines: 9 Mat Martineau wrote: > The trailing ';' on EFI_CERT_X509_SHA256_GUID could trip someone up later. As > long as you're fixing that, the spaces before the closing parens are > inconsistent with the other GUID definitions in this file. Fixed, thanks. David