From: Arnd Bergmann <arnd@arndb.de>
To: Lukas Wunner <lukas@wunner.de>
Cc: Andreas Noever <andreas.noever@gmail.com>,
        Matt Fleming <matt@codeblueprint.co.uk>,
        Ingo Molnar <mingo@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] thunderbolt: fix compile-test dependencies
Date: Thu, 17 Nov 2016 11:00:31 +0100
Message-ID: <3610890.M3zdj8M1ex@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <20161115162134.GA10928@wunner.de>
References: <20161115155908.650902-1-arnd@arndb.de> <20161115162134.GA10928@wunner.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1202
Lines: 37

On Tuesday, November 15, 2016 5:21:34 PM CET Lukas Wunner wrote:
> On Tue, Nov 15, 2016 at 04:58:53PM +0100, Arnd Bergmann wrote:
> > diff --git a/drivers/thunderbolt/Kconfig b/drivers/thunderbolt/Kconfig
> > index 0056df7f3c09..4e7d92193b65 100644
> > --- a/drivers/thunderbolt/Kconfig
> > +++ b/drivers/thunderbolt/Kconfig
> > @@ -1,7 +1,8 @@
> >  menuconfig THUNDERBOLT
> >  	tristate "Thunderbolt support for Apple devices"
> > +	depends on (EFI_STUB && X86) || COMPILE_TEST
> 
> This addition isn't correct, the thunderbolt driver works without
> the EFI stub, it just falls back to a hardcoded Device ROM.

Ok, makes sense.

I also needed this one though:

diff --git a/drivers/thunderbolt/Kconfig b/drivers/thunderbolt/Kconfig
index bb0318ceaf93..de5d27ec67d6 100644
--- a/drivers/thunderbolt/Kconfig
+++ b/drivers/thunderbolt/Kconfig
@@ -1,7 +1,7 @@
 menuconfig THUNDERBOLT
 	tristate "Thunderbolt support for Apple devices"
 	depends on PCI
-	select APPLE_PROPERTIES if EFI_STUB
+	select APPLE_PROPERTIES if EFI_STUB && X86
 	select CRC32
 	help
 	  Cactus Ridge Thunderbolt Controller driver


Without that change, building on ARM with EFI_STUB enabled still
gives me a build failure.

	Arnd