Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753268AbcKQKWL (ORCPT ); Thu, 17 Nov 2016 05:22:11 -0500 Received: from mail.skyhub.de ([78.46.96.112]:43186 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751788AbcKQKWI (ORCPT ); Thu, 17 Nov 2016 05:22:08 -0500 Date: Thu, 17 Nov 2016 11:22:04 +0100 From: Borislav Petkov To: yanjiang.jin@windriver.com Cc: morbidrsa@gmail.com, mchehab@kernel.org, york.sun@nxp.com, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, jinyanjing@gmail.com Subject: Re: [PATCH] edac: mpc85xx: implement "remove" for mpc85xx_pci_err_driver Message-ID: <20161117102204.daoziitohia2zptx@pd.tnic> References: <1479351380-17109-1-git-send-email-yanjiang.jin@windriver.com> <1479351380-17109-2-git-send-email-yanjiang.jin@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1479351380-17109-2-git-send-email-yanjiang.jin@windriver.com> User-Agent: NeoMutt/20161014 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1321 Lines: 51 On Thu, Nov 17, 2016 at 10:56:20AM +0800, yanjiang.jin@windriver.com wrote: > From: Yanjiang Jin > > Tested on a T4240QDS board. > > If we execute the below steps without this patch: > > 1. modprobe mpc85xx_edac [The first insmod, everything is well.] > 2. modprobe -r mpc85xx_edac > 3. modprobe mpc85xx_edac [insmod again, error happens.] > > We would get the error messages as below: > > BUG: recent printk recursion! > Oops: Kernel access of bad area, sig: 11 [#48] > Modules linked in: mpc85xx_edac edac_core softdog [last unloaded: mpc85xx_edac] > CPU: 5 PID: 14773 Comm: modprobe Tainted: G D C 4.8.3-rt2 > > .vsnprintf > .vscnprintf > .vprintk_emit > .printk > .edac_pci_add_device > .mpc85xx_pci_err_probe > .platform_drv_probe > .driver_probe_device > .__driver_attach > .bus_for_each_dev > .driver_attach > .bus_add_driver > .driver_register > .__platform_register_drivers > .mpc85xx_mc_init > .do_one_initcall > .do_init_module > .load_module > .SyS_finit_module > system_call > > Signed-off-by: Yanjiang Jin > --- > drivers/edac/mpc85xx_edac.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) Applied, thanks. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.