Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2993606AbcKQKve (ORCPT ); Thu, 17 Nov 2016 05:51:34 -0500 Received: from narfation.org ([79.140.41.39]:54320 "EHLO v3-1039.vlinux.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422680AbcKQKva (ORCPT ); Thu, 17 Nov 2016 05:51:30 -0500 Authentication-Results: v3-1039.vlinux.de; dmarc=none header.from=narfation.org From: Sven Eckelmann To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Linus =?ISO-8859-1?Q?L=FCssing?= , Simon Wunderlich Subject: Re: [PATCH 4.8 78/92] batman-adv: fix splat on disabling an interface Date: Thu, 17 Nov 2016 11:51:24 +0100 Message-ID: <8968438.8jDTpzOKUM@bentobox> User-Agent: KMail/5.2.3 (Linux/4.7.0-1-amd64; KDE/5.27.0; x86_64; ; ) In-Reply-To: <20161117103227.709330459@linuxfoundation.org> References: <20161117103224.218007793@linuxfoundation.org> <20161117103227.709330459@linuxfoundation.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart3584533.LTkUtWCD2B"; micalg="pgp-sha512"; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2277 Lines: 68 --nextPart3584533.LTkUtWCD2B Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" On Donnerstag, 17. November 2016 11:32:51 CET Greg Kroah-Hartman wrote: > 4.8-stable review patch. If anyone has any objections, please let me kno= w. >=20 > ------------------ >=20 > From: Linus L=FCssing >=20 > commit 9799c50372b23ed774791bdb87d700f1286ee8a9 upstream. >=20 > As long as there is still a reference for a hard interface held, there mi= ght > still be a forwarding packet relying on its attributes. >=20 > Therefore avoid setting hard_iface->soft_iface to NULL when disabling a h= ard > interface. >=20 > This fixes the following, potential splat: >=20 [...] Thanks for your backporting efforts. There is already a revert for this pat= ch queued up in batadv/net [1] (targets net.git). So maybe you want to drop th= is patch from your stable queue. We also got test results from Linus which showed that this problem didn't happen anymore with recent kernel versions (without his patch). These resul= ts made him also Ack the revert. Sorry about this confusing situation. Kind regards, Sven [1] https://git.open-mesh.org/linux-merge.git/commit/27915aa61060fd8954a68a= 86657784705955088a --nextPart3584533.LTkUtWCD2B Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIcBAABCgAGBQJYLYusAAoJEF2HCgfBJntGE2YP/3Jt5KQOY6vEZgkM6tChpMGd b5wuoIsZm+sxL7cY3SVvC8pe8WIayrtdIiiPWZpkSBYCnkEc45derQtY9TU8GUHC lOYmAeJWB+J8jJkKKkasdK/Ozpyb61GvNEdK22oDy0qolk27Uk3gzDucWSy14Zyu t7Q4PeagzSxxCRelVLUwZDaiIWoviUF+Ay34jZlphx4wupxZAWIb+FLLuv5Rgc4l HU5GjV/2nKxXqnCiMO4BjvE+33hDvgmRWho2IA2w+sixG4/MRb2ZYA57p4gRlNLI 3cdT4ggGflpZBe/CjqKHOx0dGUCZ7GJJMJpf0qSoXa3PCKN7KCSI8C0dnZGYg3x0 8G8QVyKUVOJQObz5X7Hi9E6dURdiTLEgE3bkAi03NEaopQcp7rHg+uLZc96IfY39 vdrRuLecC2je9APSr4naz6kf9yVKwpP7NZKq8ydckBXy2CrfAh9nvk3Tkgvm50i0 +juUSjBPkEY2zCZPiImzZhdk1jFrjPpDLm/tTm5r8Fi3uub15rSFWiedW+c2Vaur zD6F+aBUhoqUdwkQPkBS15YHU3mjKXmbLmptEmq2xWxV2R7q/dO0hyC1x5CnS8hp 6KL9hbLblR8dS94eSuxT2kD8PDJJaIkdcPzEoLcor6KCnEg566QRm/oQlfESSqyc Th8ziIGvB6crLUep1Qza =y5mY -----END PGP SIGNATURE----- --nextPart3584533.LTkUtWCD2B--