Date: Thu, 17 Nov 2016 13:02:57 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sven Eckelmann <sven@narfation.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Linus =?iso-8859-1?Q?L=FCssing?= <linus.luessing@c0d3.blue>,
        Simon Wunderlich <sw@simonwunderlich.de>
Subject: Re: [PATCH 4.8 78/92] batman-adv: fix splat on disabling an interface
Message-ID: <20161117120257.GB22450@kroah.com>
References: <20161117103224.218007793@linuxfoundation.org>
 <20161117103227.709330459@linuxfoundation.org>
 <8968438.8jDTpzOKUM@bentobox>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <8968438.8jDTpzOKUM@bentobox>
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1212
Lines: 34

On Thu, Nov 17, 2016 at 11:51:24AM +0100, Sven Eckelmann wrote:
> On Donnerstag, 17. November 2016 11:32:51 CET Greg Kroah-Hartman wrote:
> > 4.8-stable review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: Linus L?ssing <linus.luessing@c0d3.blue>
> > 
> > commit 9799c50372b23ed774791bdb87d700f1286ee8a9 upstream.
> > 
> > As long as there is still a reference for a hard interface held, there might
> > still be a forwarding packet relying on its attributes.
> > 
> > Therefore avoid setting hard_iface->soft_iface to NULL when disabling a hard
> > interface.
> > 
> > This fixes the following, potential splat:
> > 
> [...]
> 
> Thanks for your backporting efforts. There is already a revert for this patch
> queued up in batadv/net [1] (targets net.git). So maybe you want to drop this
> patch from your stable queue.
> 
> We also got test results from Linus which showed that this problem didn't
> happen anymore with recent kernel versions (without his patch). These results
> made him also Ack the revert.
> 
> Sorry about this confusing situation.

Not a problem, I've dropped this one from the patch queue now, thanks
for letting me know.

greg k-h