Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936539AbcKQRar (ORCPT ); Thu, 17 Nov 2016 12:30:47 -0500 Received: from aserp1050.oracle.com ([141.146.126.70]:35330 "EHLO aserp1050.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754174AbcKQRAQ (ORCPT ); Thu, 17 Nov 2016 12:00:16 -0500 Subject: Re: [PATCH v2] xen/gntdev: Use mempolicy instead of VM_IO flag to avoid NUMA balancing To: Olaf Hering References: <1479318378-595-1-git-send-email-boris.ostrovsky@oracle.com> <20161117112843.GA19761@aepfle.de> <20161117160140.GB19761@aepfle.de> Cc: david.vrabel@citrix.com, jgross@suse.com, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org From: Boris Ostrovsky Message-ID: <057d38c5-4e1a-21dd-c51d-010b1dfdc752@oracle.com> Date: Thu, 17 Nov 2016 11:09:22 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161117160140.GB19761@aepfle.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Eithq2afD1DoMJCNW9B1B9lIGutHTXqL4" X-Source-IP: aserp1040.oracle.com [141.146.126.69] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2649 Lines: 66 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Eithq2afD1DoMJCNW9B1B9lIGutHTXqL4 Content-Type: multipart/mixed; boundary="Mu5sugjXPOMXcmE7gPRSACajDLJttHrfn"; protected-headers="v1" From: Boris Ostrovsky To: Olaf Hering Cc: david.vrabel@citrix.com, jgross@suse.com, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Message-ID: <057d38c5-4e1a-21dd-c51d-010b1dfdc752@oracle.com> Subject: Re: [PATCH v2] xen/gntdev: Use mempolicy instead of VM_IO flag to avoid NUMA balancing References: <1479318378-595-1-git-send-email-boris.ostrovsky@oracle.com> <20161117112843.GA19761@aepfle.de> <20161117160140.GB19761@aepfle.de> In-Reply-To: <20161117160140.GB19761@aepfle.de> --Mu5sugjXPOMXcmE7gPRSACajDLJttHrfn Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/17/2016 11:01 AM, Olaf Hering wrote: > On Thu, Nov 17, Boris Ostrovsky wrote: > >> On 11/17/2016 06:28 AM, Olaf Hering wrote: >>> ERROR: "__mpol_dup" [drivers/xen/xen-gntdev.ko] undefined! >>> ERROR: "get_task_policy" [drivers/xen/xen-gntdev.ko] undefined! >> I just built 4.4.11 with this patch applied and haven't had any proble= ms. > Are these functions exported? How would the driver module call into the= > core kernel? Maybe the added functionality should be provided by an > exported helper function. You are right --- I didn't realize was building with grant device built-in. So yes, this needs to be fixed. -boris --Mu5sugjXPOMXcmE7gPRSACajDLJttHrfn-- --Eithq2afD1DoMJCNW9B1B9lIGutHTXqL4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYLdYyAAoJEIredpCGysGybioP+gJTEsmXSacPHk/dJ3U/quSo Vb1xYcM7Q/jMJbXODJ5XOuZhwOiBfXo9yvcsg8IonQnHdvK6IwGybRvU9f7bj6mz k1WYPz6aMPHI8mhGHkN8sRa9yzaxnz14mbRObPC42qyS7VIYtw8P8PsqmIZmgG/D pZhDpJTbPb8k1M5FYPs8HMPj3jP2hDcPs/KxUnRdy7v1ibXgHzmmIZKSZc89Np6o q3c8ks6MjOa0/k5bF4IN1itihAKZcjgEk3el6Zqd6H1ZE5CqPKgBOg4KQ6crgCLG T4MXsFhoE82+N2SM3SHVh270m6aaaelzCS9fY/wNKswJU3FA0WweF8EeL0AkG1tj Nu/e1SmYPdYw7m+vLt+kZkBy+qsJICTzD6mLyKtkL/K0ZmTV/YypF7PppUbpaRQR cYjOMbR2lrDE1z5pB18x1pD7ZH7H+yUzy3LzULmIQvzA1IaMhqXMgXVBMTt6uPFQ Yk7aadPXdUAcdJRSegzVff0h/OhaMZlJaUdvuThV5roS9ZJeERKYHhqEKgJp0KUa ExBi+bxheRz4GfhHwjPn0LK4dkK1h1P+b3Mg1r1/DsFRNOH5qpebpN6pKWsSajt5 v42CdMr/CUtDdFiizURKil5jU6VX2vwZVZzlqL4T6s8JG7EzPHNe1gyAExSymhlc 7VFZ7HhFca0vXYXo6ZIk =cDuY -----END PGP SIGNATURE----- --Eithq2afD1DoMJCNW9B1B9lIGutHTXqL4--