Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936440AbcKQRyW (ORCPT ); Thu, 17 Nov 2016 12:54:22 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45569 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932132AbcKQRyU (ORCPT ); Thu, 17 Nov 2016 12:54:20 -0500 Date: Thu, 17 Nov 2016 08:27:37 -0700 From: Alex Williamson To: Jike Song Cc: Kirti Wankhede , pbonzini@redhat.com, kraxel@redhat.com, cjia@nvidia.com, qemu-devel@nongnu.org, kvm@vger.kernel.org, kevin.tian@intel.com, bjsdjshi@linux.vnet.ibm.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v14 12/22] vfio: Add notifier callback to parent's ops structure of mdev Message-ID: <20161117082737.7f6ff329@t450s.home> In-Reply-To: <582DA41A.7010204@intel.com> References: <1479329194-10247-1-git-send-email-kwankhede@nvidia.com> <1479329194-10247-13-git-send-email-kwankhede@nvidia.com> <582DA41A.7010204@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Thu, 17 Nov 2016 15:27:38 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1038 Lines: 27 On Thu, 17 Nov 2016 20:35:38 +0800 Jike Song wrote: > On 11/17/2016 04:46 AM, Kirti Wankhede wrote: > > Add a notifier calback to parent's ops structure of mdev device so that per > > device notifer for vfio module is registered through vfio_mdev module. > > > > Signed-off-by: Kirti Wankhede > > Signed-off-by: Neo Jia > > Change-Id: Iafa6f1721aecdd6e50eb93b153b5621e6d29b637 > > --- > > drivers/vfio/mdev/vfio_mdev.c | 34 +++++++++++++++++++++++++++++++++- > > include/linux/mdev.h | 9 +++++++++ > > 2 files changed, 42 insertions(+), 1 deletion(-) > > > > Hi Alex, Kirti, > > Since everyone agreed we should let the vendor driver call vfio_register_notifier > directly, can you drop this patch from merging? So that I don't need to send a > reverse patch. This seems like a reasonable request to me, this patch drops cleanly from the series. Any objection Kirti? It seems like it removes a little bit of pre-release churn from the API. Thanks, Alex