Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754764AbcKQSbB (ORCPT ); Thu, 17 Nov 2016 13:31:01 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:40970 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754582AbcKQSbA (ORCPT ); Thu, 17 Nov 2016 13:31:00 -0500 Date: Thu, 17 Nov 2016 13:30:58 -0500 (EST) Message-Id: <20161117.133058.1156121923515618186.davem@davemloft.net> To: clabbe.montjoie@gmail.com Cc: peppe.cavallaro@st.com, alexandre.torgue@st.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] net: stmmac: replace all pr_xxx by their netdev_xxx counterpart From: David Miller In-Reply-To: <1479323381-26639-1-git-send-email-clabbe.montjoie@gmail.com> References: <1479323381-26639-1-git-send-email-clabbe.montjoie@gmail.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 17 Nov 2016 09:31:31 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1156 Lines: 28 From: Corentin Labbe Date: Wed, 16 Nov 2016 20:09:39 +0100 > From: LABBE Corentin > > The stmmac driver use lots of pr_xxx functions to print information. > This is bad since we cannot know which device logs the information. > (moreover if two stmmac device are present) > > Furthermore, it seems that it assumes wrongly that all logs will always > be subsequent by using a dev_xxx then some indented pr_xxx like this: > kernel: sun7i-dwmac 1c50000.ethernet: no reset control found > kernel: Ring mode enabled > kernel: No HW DMA feature register supported > kernel: Normal descriptors > kernel: TX Checksum insertion supported > > So this patch replace all pr_xxx by their netdev_xxx counterpart. > Excepts for some printing where netdev "cause" unpretty output like: > sun7i-dwmac 1c50000.ethernet (unnamed net_device) (uninitialized): no reset control found > In those case, I keep dev_xxx. > > In the same time I remove some "stmmac:" print since > this will be a duplicate with that dev_xxx displays. > > Signed-off-by: Corentin Labbe Applied to net-next.