Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933918AbcKQTEX (ORCPT ); Thu, 17 Nov 2016 14:04:23 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41214 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752323AbcKQTEW (ORCPT ); Thu, 17 Nov 2016 14:04:22 -0500 Date: Thu, 17 Nov 2016 20:04:20 +0100 From: Oleg Nesterov To: Jamie Iles Cc: linux-kernel@vger.kernel.org, Alexander Viro , Ingo Molnar , Peter Zijlstra , Andrew Morton Subject: Re: [PATCH] signal: protect SIGNAL_UNKILLABLE from unintentional clearing. Message-ID: <20161117190420.GA23492@redhat.com> References: <20161116125759.4727-1-jamie.iles@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161116125759.4727-1-jamie.iles@oracle.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 17 Nov 2016 19:04:21 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 548 Lines: 18 On 11/16, Jamie Iles wrote: > > This can result in init becoming stoppable/killable after tracing. For > example, running: > > while true; do kill -STOP 1; done & > strace -p 1 > and then stopping strace and the kill loop will result in init being > left in state TASK_STOPPED. Sending SIGCONT to init will resume it, but > init will now respond to future SIGSTOP signals rather than ignoring > them. Yes, and a lot more... I forgot about these problems again. Jamie, sorry for delay, I'll try to read the patch and reply tomorrow. Oleg.