Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752399AbcKQUks (ORCPT ); Thu, 17 Nov 2016 15:40:48 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:50720 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751059AbcKQUkq (ORCPT ); Thu, 17 Nov 2016 15:40:46 -0500 Date: Thu, 17 Nov 2016 21:40:43 +0100 From: Maxime Ripard To: Chen-Yu Tsai Cc: Linus Walleij , Klaus Goger , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH] ARM: dts: sunxi: Explicitly enable pull-ups for MMC pins Message-ID: <20161117204043.wz66gpsb4y2pt7yu@lukather> References: <20161117093438.17988-1-wens@csie.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="iw4zlf3tz5you664" Content-Disposition: inline In-Reply-To: <20161117093438.17988-1-wens@csie.org> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1845 Lines: 52 --iw4zlf3tz5you664 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 17, 2016 at 05:34:38PM +0800, Chen-Yu Tsai wrote: > In the past, all the MMC pins had >=20 > allwinner,pull =3D ; >=20 > which was actually a no-op. We were relying on U-boot to set the bias > pull up for us. These properties were removed as part of the fix up to > actually support no bias on the pins. During the transition some boards > experienced regular MMC time-outs during normal operation, while others > completely failed to initialize the SD card. >=20 > Given that MMC starts in open-drain mode and the pull-ups are required, > it's best to enable it for all the pin settings. >=20 > Signed-off-by: Chen-Yu Tsai Applied, thanks. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --iw4zlf3tz5you664 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJYLhXLAAoJEBx+YmzsjxAgjtIP/1y5xdGfYh8F8cZXYXTxif1U htH/LUSz0hmgW9GVgZSiCpj+3DaFyiN5LzPV9yafxLE7N8vuPaml1p19bAOLarLJ xeD8X77xcw1T4JoBT2juX9M7blaG5Z7FVX2PiLQo6FJI6gYWpMyN7pTsG5WZTmp7 bIPjcxaO8tzmlqQkE9GFO554sBFiPA47gTI6UcU2MjhIIcHbvRnJQTDEctoTMEdy 30isGX61+RY35HtNyAL3SM9Dim+DBQI9lpVqbpBUooUwKfiGeDNy2+VTTz8Owrdg S0PfmKRWa2F0u75Tj61S9deTG9UVdIxamOQQLr41QTQTii/n0pZejNtbHUrU6U1p 84B2xgdFas/FbvwNA+K7SVQTCOFsqkBHDS168O4RCu3uT6skY9SiYHyuKCRlgf4e UlDgCa+JpyMTLv0/YyH/HtmYFrlCSaXnVxtzFWHPc6KB02xQaLkcuBhjt+eDxbd6 lsYF+kJhnh28BYcz7pF7pJURA9u8ihvh+WDWQwFrL8FT3mASRy3rTv2JT+Wizgd1 HdsLk5RH7hhVT7POhgTd2Asb1wE6LY5pfGjsi3o0E7DaLtqZHhARkUTMl/+D62L3 A4vazBGnNar0/p4VNGV1KtPkI/u0pD4PcA3RfTUkBTDrMrcP58rVFvmBP5HRukYN 5WgBIHd/CKTl+0gZrAuV =HlK6 -----END PGP SIGNATURE----- --iw4zlf3tz5you664--