Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752583AbcKQWQL (ORCPT ); Thu, 17 Nov 2016 17:16:11 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:45890 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750855AbcKQWQJ (ORCPT ); Thu, 17 Nov 2016 17:16:09 -0500 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 229976232F Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=sboyd@codeaurora.org Subject: Re: [PATCH] ARM: dts: qcom: Add apq8064 CoreSight components To: Georgi Djakov , andy.gross@linaro.org References: <20161117153609.11705-1-georgi.djakov@linaro.org> Cc: robh+dt@kernel.org, devicetree@vger.kernel.org, mathieu.poirier@linaro.org, zhang.chunyan@linaro.org, iivanov.xz@gmail.com, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: Stephen Boyd Message-ID: Date: Thu, 17 Nov 2016 14:16:06 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161117153609.11705-1-georgi.djakov@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 922 Lines: 21 On 11/17/2016 07:36 AM, Georgi Djakov wrote: > From: "Ivan T. Ivanov" > > Add initial set of CoreSight components found on Qualcomm's > 8064 chipset. > > Signed-off-by: Ivan T. Ivanov > Signed-off-by: Georgi Djakov > --- > arch/arm/boot/dts/qcom-apq8064-coresight.dtsi | 196 ++++++++++++++++++++++++++ Why not put this inside the soc file? This would be the first time we add a new file for something that's inside the SoC node that probably won't change thereafter. At least for pins I slightly agree with having a different file, we're adding more and more things there so it's nice to have a consolidated place of all possible configurations to choose from. But here it's mostly a static device description so what's the gain? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project