Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752852AbcKQXNO (ORCPT ); Thu, 17 Nov 2016 18:13:14 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:36672 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751058AbcKQXNL (ORCPT ); Thu, 17 Nov 2016 18:13:11 -0500 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 31F5C616FC Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=sboyd@codeaurora.org Date: Thu, 17 Nov 2016 15:13:09 -0800 From: Stephen Boyd To: Sarangdhar Joshi Cc: Andy Gross , David Brown , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson , Jordan Crouse , Trilok Soni Subject: Re: [PATCH v3 3/3] firmware: qcom: scm: Return PTR_ERR when devm_clk_get fails Message-ID: <20161117231309.GV25626@codeaurora.org> References: <1479259165-1601-1-git-send-email-spjoshi@codeaurora.org> <1479259165-1601-4-git-send-email-spjoshi@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1479259165-1601-4-git-send-email-spjoshi@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 561 Lines: 15 On 11/15, Sarangdhar Joshi wrote: > When devm_clk_get fails for core clock, the failure was ignored > and the core_clk was explicitly set to NULL so that other > remaining clocks can be queried. However, now that we have a > cleaner way of expressing the clock dependency, return failure > when devm_clk_get fails for core clock. > > Signed-off-by: Sarangdhar Joshi > --- Reviewed-by: Stephen Boyd -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project