MIME-Version: 1.0
In-Reply-To: <20161114061858.gklgk5go2qxq4b5y@pd.tnic>
References: <20161111101930.32559-1-bp@alien8.de> <20161112110649.GA28774@gmail.com>
 <20161112122736.fmiowshbus5hjjnb@pd.tnic> <CALCETrW2DrMLVsiopx=GohC9v1pWFz3149wmAqRY_8QC=qDfTQ@mail.gmail.com>
 <20161114061858.gklgk5go2qxq4b5y@pd.tnic>
From: Andy Lutomirski <luto@amacapital.net>
Date: Thu, 17 Nov 2016 15:33:21 -0800
Message-ID: <CALCETrUU2rVQ14vVfR4pWA+J9dw=EoSmACHsnrXhg5b4sWbuAg@mail.gmail.com>
Subject: Re: [RFC PATCH] x86/debug: Dump more detailed segfault info
To: Borislav Petkov <bp@alien8.de>
Cc: Ingo Molnar <mingo@kernel.org>, X86 ML <x86@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Linus Torvalds <torvalds@linux-foundation.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 590
Lines: 16

On Nov 13, 2016 10:18 PM, "Borislav Petkov" <bp@alien8.de> wrote:
>
> On Sun, Nov 13, 2016 at 08:15:01AM -0800, Andy Lutomirski wrote:
> > How about dropping the __ in front of the copy?
>
> In front of __copy_from_user_inatomic()?
>
> If so, is there even a global helper by that name?
>
> $ git grep -E "[^_]copy_from_user_inatomic"
> drivers/gpu/drm/msm/msm_gem_submit.c:98:                ret = copy_from_user_inatomic(&submit_bo, userptr, sizeof(submit_bo));
>
> is all I can find.

Huh, go figure.  How about access_ok() instead?  There's also
pagefault_disable() + copy_from_user().