Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752190AbcKRH1c (ORCPT ); Fri, 18 Nov 2016 02:27:32 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:32775 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751662AbcKRH13 (ORCPT ); Fri, 18 Nov 2016 02:27:29 -0500 Date: Fri, 18 Nov 2016 08:27:23 +0100 From: Ingo Molnar To: Kyle Huey Cc: "Robert O'Callahan" , Thomas Gleixner , Andy Lutomirski , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Paolo Bonzini , Radim =?utf-8?B?S3LEjW3DocWZ?= , Jeff Dike , Richard Weinberger , Alexander Viro , Shuah Khan , Dave Hansen , Borislav Petkov , Peter Zijlstra , Boris Ostrovsky , Len Brown , "Rafael J. Wysocki" , Dmitry Safonov , David Matlack , Nadav Amit , linux-kernel@vger.kernel.org, user-mode-linux-devel@lists.sourceforge.net, user-mode-linux-user@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH v12 2/7] x86/arch_prctl/64: Rename do_arch_prctl to do_arch_prctl_64 Message-ID: <20161118072723.GA15912@gmail.com> References: <20161117020610.5302-1-khuey@kylehuey.com> <20161117020610.5302-3-khuey@kylehuey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161117020610.5302-3-khuey@kylehuey.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 576 Lines: 18 * Kyle Huey wrote: > In order to introduce new arch_prctls that are not 64 bit only, rename the > existing 64 bit implementation to do_arch_prctl_64(). Also rename the second > argument to arch_prctl(), which will no longer always be an address. > #ifdef CONFIG_X86_64 > void entry_SYSCALL_64(void); > +long do_arch_prctl_64(struct task_struct *task, int code, unsigned long arg2); > #endif Could you please also rename the weirdly named 'code' argument to 'option', to be in line with the existing sys_prctl() interface nomenclature? Thanks, Ingo