Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752817AbcKRIs0 (ORCPT ); Fri, 18 Nov 2016 03:48:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46182 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751527AbcKRIsY (ORCPT ); Fri, 18 Nov 2016 03:48:24 -0500 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <1479407964.4556.5.camel@redhat.com> References: <1479407964.4556.5.camel@redhat.com> <147938969703.13574.10295364502230379833.stgit@warthog.procyon.org.uk> <147938970382.13574.11581172952175034619.stgit@warthog.procyon.org.uk> To: Jeff Layton Cc: dhowells@redhat.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <25388.1479458901.1@warthog.procyon.org.uk> Date: Fri, 18 Nov 2016 08:48:21 +0000 Message-ID: <25389.1479458901@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Fri, 18 Nov 2016 08:48:23 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 356 Lines: 15 Jeff Layton wrote: > > If neither AT_STATX_*_SYNC flag is set, the behaviour is the default for > > stat() on that filesystem. > > > > We also need to specify here what happens if both bits are set. Should > that be -EINVAL? Makes sense. This leads to another thought: should fstatat() be allowed to take AT_STATX_* flags? David