Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752396AbcKRJDP (ORCPT ); Fri, 18 Nov 2016 04:03:15 -0500 Received: from szxga01-in.huawei.com ([58.251.152.64]:52445 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751556AbcKRJDK (ORCPT ); Fri, 18 Nov 2016 04:03:10 -0500 Subject: Re: [RFC PATCH] scsi: libsas: fix WARN on device removal To: Dan Williams References: <1478185120-5509-1-git-send-email-john.garry@huawei.com> <9870e7bc-a472-1913-1930-ac022e8ad5e8@huawei.com> <58257D52.6090507@huawei.com> <93ae84f6-75a2-f576-808e-f98c6256b6a6@huawei.com> <58258631.1090203@huawei.com> <9bdd2ca5-aa72-6a18-b66d-8e791e4852c7@huawei.com> CC: , "Martin K. Petersen" , wangyijing , linux-scsi , John Garry , "linux-kernel@vger.kernel.org" , , , Tejun Heo , Jinpu Wang From: John Garry Message-ID: Date: Fri, 18 Nov 2016 09:00:54 +0000 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.181.159] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1239 Lines: 38 On 18/11/2016 01:53, Dan Williams wrote: > On Thu, Nov 17, 2016 at 7:23 AM, John Garry wrote: >> On 11/11/2016 08:49, wangyijing wrote: >>>>>> >>>>>> I have not seen the flutter issue. I am just trying to solve the >>>>>> horrible WARN dump. >>>>>> However I do understand that there may be a issue related to how we >>>>>> queue the events; there was a recent attempt to fix this, but it came to >>>>>> nothing: >>>>>> https://www.spinics.net/lists/linux-scsi/msg99991.html >>>>> >>>>> >>>>> We found libsas hotplug several problems: >>>>> 1. sysfs warning calltrace(like the case you found); >>>> >>>> >>>> Maybe you can then review my patch. >>> >>> >>> I did it, I think your solution to fix the sysfs calltrace issue is ok, >>> and what I worried about is we still need to fix >>> the rest issues. So it's better if we could fix all issues one time. >>> >> >> @Maintainers, would you be willing to accept this patch as an interim fix >> for the dastardly WARN while we try to fix the flutter issue? > > To me this adds a bug to quiet a benign, albeit noisy, warning. > What is the bug which is being added? And it's a very noisy warning, as in 6K lines on the console when an expander is unplugged. > . >