Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752901AbcKRJKS (ORCPT ); Fri, 18 Nov 2016 04:10:18 -0500 Received: from mail-ua0-f171.google.com ([209.85.217.171]:34334 "EHLO mail-ua0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752090AbcKRJKP (ORCPT ); Fri, 18 Nov 2016 04:10:15 -0500 MIME-Version: 1.0 In-Reply-To: <3477625.cZS9dUaHfE@wuerfel> References: <1477551554-30349-1-git-send-email-binoy.jayan@linaro.org> <3477625.cZS9dUaHfE@wuerfel> From: Binoy Jayan Date: Fri, 18 Nov 2016 14:40:13 +0530 Message-ID: Subject: Re: [PATCH v4 05/10] IB/isert: Replace semaphore sem with completion To: Arnd Bergmann , Mark Brown Cc: Sagi Grimberg , Doug Ledford , Sean Hefty , Hal Rosenstock , linux-rdma@vger.kernel.org, Linux kernel mailing list Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 729 Lines: 21 Hi Arnd, On 18 November 2016 at 14:28, Arnd Bergmann wrote: > On Friday, November 18, 2016 12:27:32 PM CET Binoy Jayan wrote: >> Hi Sagi, > I think you are right. This is behavior is actuallly documented in > Documentation/scheduler/completion.txt: Thanking for having a look. > However, this is fairly unusual behavior and I wasn't immediately aware > of it either when I read Sagi's reply. While your patch looks correct, > it's probably a good idea to point out the counting behavior of this > completion as explicitly as possible, in the changelog text of the patch > as well as in a code comment and perhaps in the naming of the completion. Will mention this and resend the patch series. Thanks, Binoy