Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752771AbcKRLBJ (ORCPT ); Fri, 18 Nov 2016 06:01:09 -0500 Received: from ozlabs.org ([103.22.144.67]:45177 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752563AbcKRLBH (ORCPT ); Fri, 18 Nov 2016 06:01:07 -0500 From: Michael Ellerman To: bamvor.zhangjian@huawei.com, shuahkh@osg.samsung.com Cc: linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, khilman@linaro.org, broonie@kernel.org Subject: Re: [PATCH RFC 5/6] selftests: add EXTRA_CLEAN for clean target In-Reply-To: <1477047694-24122-6-git-send-email-bamvor.zhangjian@huawei.com> References: <1477047694-24122-1-git-send-email-bamvor.zhangjian@huawei.com> <1477047694-24122-6-git-send-email-bamvor.zhangjian@huawei.com> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Fri, 18 Nov 2016 22:01:04 +1100 Message-ID: <87bmxdgihb.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1376 Lines: 36 bamvor.zhangjian@huawei.com writes: > From: Bamvor Jian Zhang > > Some testcases need the clean extra data after running. This patch > introduce the "EXTRA_CLEAN" variable to address this requirement. The idea here is fine I think. But this will need reworking if you follow my suggestions for patch 1. > After KOUTPUT_BUILD is enabled in later patch, it will be easy to > decide to if we need do the cleanup in the KOUTPUT_BUILD path, if the > testcase ran immediately after compiled. > > Signed-off-by: Bamvor Jian Zhang All of these: > tools/testing/selftests/powerpc/benchmarks/Makefile | 5 ++--- > tools/testing/selftests/powerpc/copyloops/Makefile | 3 +-- > tools/testing/selftests/powerpc/dscr/Makefile | 4 ++-- > tools/testing/selftests/powerpc/math/Makefile | 5 ++--- > tools/testing/selftests/powerpc/primitives/Makefile | 5 ++--- > tools/testing/selftests/powerpc/stringloops/Makefile | 5 ++--- > tools/testing/selftests/powerpc/syscalls/Makefile | 5 ++--- > tools/testing/selftests/powerpc/tm/Makefile | 5 ++--- are just cleaning *.o, and I'm pretty sure none of them need to. So for those you can just drop the custom clean rule. This one does need a custom rule: > .../testing/selftests/powerpc/switch_endian/Makefile | 5 ++--- cheers