Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753129AbcKRLUQ (ORCPT ); Fri, 18 Nov 2016 06:20:16 -0500 Received: from vm1.sequanux.org ([188.165.36.56]:60565 "EHLO vm1.sequanux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753070AbcKRLUN (ORCPT ); Fri, 18 Nov 2016 06:20:13 -0500 Date: Fri, 18 Nov 2016 12:20:07 +0100 From: Simon Guinot To: "Levy, Amir (Jer)" Cc: "gregkh@linuxfoundation.org" , "andreas.noever@gmail.com" , "bhelgaas@google.com" , "corbet@lwn.net" , "linux-kernel@vger.kernel.org" , "linux-pci@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-doc@vger.kernel.org" , "mario_limonciello@dell.com" , thunderbolt-linux , "Westerberg, Mika" , "Winkler, Tomas" , "Zhang, Xiong Y" , "Jamet, Michael" , "remi.rerolle@seagate.com" Subject: Re: [PATCH v9 0/8] thunderbolt: Introducing Thunderbolt(TM) Networking Message-ID: <20161118112007.GB1230@kw.sim.vm.gnt> References: <1478701208-4585-1-git-send-email-amir.jer.levy@intel.com> <20161109143632.GE6167@kw.sim.vm.gnt> <20161115105920.GH6167@kw.sim.vm.gnt> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="aVD9QWMuhilNxW9f" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4444 Lines: 117 --aVD9QWMuhilNxW9f Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 18, 2016 at 08:48:36AM +0000, Levy, Amir (Jer) wrote: > On Tue, Nov 15 2016, 12:59 PM, Simon Guinot wrote: > > On Wed, Nov 09, 2016 at 03:42:53PM +0000, Levy, Amir (Jer) wrote: > > > On Wed, Nov 9 2016, 04:36 PM, Simon Guinot wrote: > > > > Hi Amir, > > > > > > > > I have an ASUS "All Series/Z87-DELUXE/QUAD" motherboard with a=20 > > > > Thunderbolt 2 "Falcon Ridge" chipset (device ID 156d). > > > > > > > > Is the thunderbolt-icm driver supposed to work with this chipset ? > > > > > > > > > > Yes, the thunderbolt-icm supports Falcon Ridge, device ID 156c. > > > 156d is the bridge - > > > http://lxr.free-electrons.com/source/include/linux/pci_ids.h#L2619 > > > > > > > I have installed both a 4.8.6 Linux kernel (patched with your v9 > > > > series) and the thunderbolt-software-daemon (27 october release)=20 > > > > inside a Debian system (Jessie). > > > > > > > > If I connect the ASUS motherboard with a MacBook Pro (Thunderbolt= =20 > > > > 2, device ID 156c), I can see that the thunderbolt-icm driver is=20 > > > > loaded and that the thunderbolt-software-daemon is well started.=20 > > > > But the Ethernet interface is not created. > > > > > > > > I have attached to this email the syslog file. There is the logs=20 > > > > from both the kernel and the daemon inside. Note that the daemon=20 > > > > logs are everything but clear about what could be the issue. Maybe= =20 > > > > I missed some kind of configuration ? But I failed to find any=20 > > > > valuable information about configuring the driver and/or the=20 > > > > daemon in > > the various documentation files. > > > > > > > > Please, can you provide some guidance ? I'd really like to test=20 > > > > your patch series. > > > > > > First, thank you very much for willing to test it. > > > Thunderbolt Networking support was added during Falcon Ridge, in the > > latest FR images. > > > Do you know which Thunderbolt image version you have on your system? > > > Currently I submitted only Thunderbolt Networking feature in Linux,= =20 > > > and we plan to add more features like reading the image version and > > updating the image. > > > If you don't know the image version, the only thing I can suggest is= =20 > > > to load windows, install thunderbolt SW and check in the Thunderbolt > > application the image version. > > > To know if image update is needed, you can check -=20 > > > https://thunderbolttechnology.net/updates > >=20 > > Hi Amir, > >=20 > > From the Windows Thunderbolt software, I can read 13.00 for the=20 > > firmware version. And from https://thunderbolttechnology.net/updates,= =20 > > I can see that there is no update available for my ASUS motherboard. > >=20 > > Am I good to go ? > >=20 >=20 > Thunderbolt Networking is supported on both Thunderbolt(tm) 2 and Thunder= bolt(tm) 3 systems. =20 > Thunderbolt 2 systems must have updated NVM (version 25 or later) in orde= r for the functionality to work properly. =20 > If the system does not have the update, please contact the OEM directly f= or an updated NVM. =20 > For best functionality and support, Intel recommends using Thunderbolt 3 = systems for all validation and testing. Maybe it is worth mentioning in the documentation and/or in the Kconfig help message that a minimal firmware version is needed for Thunderbolt 2 controllers. It would have saved some time for me :) >=20 > > BTW, it is quite a shame that the Thunderbolt firmware version can't=20 > > be read from Linux. > >=20 >=20 > This is WIP, once this patch will be upstream, we will be able to focus m= ore > on aligning Linux with the Thunderbolt features that we have for windows. Well, I rather see the firmware identification and update as basic features on the top of which ones you can build a driver. For example in this case this would allow the ICM driver and/or the userland daemon to exit with a useful error message rather than just not working without any explanation. Next week I'll try the driver with a Thunderbolt 3 controller. Thanks for your help! Simon --aVD9QWMuhilNxW9f Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlgu4+cACgkQgtp0PDeOcDq98wCdEqKndFp0ABwTR6vuuftV3F/d 5G4AnA43HLB8ih8nqQ6qk2S6THaRYM0i =+Swu -----END PGP SIGNATURE----- --aVD9QWMuhilNxW9f--