Date: Fri, 18 Nov 2016 12:33:35 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Dave Jiang <dave.jiang@intel.com>
cc: Ingo Molnar <mingo@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
        dan.j.williams@intel.com, x86@kernel.org, david@fromorbit.com,
        LKML <linux-kernel@vger.kernel.org>, linux-nvdimm@ml01.01.org
Subject: Re: [PATCH] x86: Add warning when memmap=nn!ss and CONFIG_RANDOMIZE_BASE
 enabled
In-Reply-To: <147941499514.131046.6450643991764692220.stgit@djiang5-desk3.ch.intel.com>
Message-ID: <alpine.DEB.2.20.1611181224440.3615@nanos>
References: <147941499514.131046.6450643991764692220.stgit@djiang5-desk3.ch.intel.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 844
Lines: 21

On Thu, 17 Nov 2016, Dave Jiang wrote:
> CONFIG_RANDOMIZE_BASE can place the kernel anywhere. This causes a problem
> for when memmap=nn!ss is used. This information is not known until after
> the kernel starts executing and the decision for where the randomized
> base goes happens before the kernel is uncompressed. memmap=nn!ss is not
> reliable in the presence of CONFIG_RANDOMIZE_BASE.

So this is a description of a problem. Now what's missing is a useful
explanation why you think that adding a warning will make things better.

IMNSHO adding that warning is just a pointless exercise. 

Why aren't you addressing the real issue and make the boot code parse that
option and prevent that region from being used for kernel placement?
 
The same issue exists for other memmap options as well, not just for that
PMEM thingy.

Thanks,

	tglx