Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753357AbcKRLkd (ORCPT ); Fri, 18 Nov 2016 06:40:33 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:32996 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752057AbcKRLkb (ORCPT ); Fri, 18 Nov 2016 06:40:31 -0500 Date: Fri, 18 Nov 2016 12:40:40 +0100 From: Greg KH To: Tal Shorer Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] usb: hcd.h: construct hub class request conastants from simpler constants Message-ID: <20161118114040.GA12190@kroah.com> References: <20161118100100.GA20048@kroah.com> <1479467899-18330-1-git-send-email-tal.shorer@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1479467899-18330-1-git-send-email-tal.shorer@gmail.com> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 261 Lines: 6 On Fri, Nov 18, 2016 at 01:18:19PM +0200, Tal Shorer wrote: > Currently, each hub class request constant is defined by a line like: > > The "magic" number for the high byte is one of 0x20, 0xa0, 0x23, 0xa3. Again, shouldn't there be something after your ":"?