Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753474AbcKRL6f (ORCPT ); Fri, 18 Nov 2016 06:58:35 -0500 Received: from mail-it0-f66.google.com ([209.85.214.66]:35565 "EHLO mail-it0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752711AbcKRL6b (ORCPT ); Fri, 18 Nov 2016 06:58:31 -0500 MIME-Version: 1.0 In-Reply-To: References: <147933283664.19316.12454053022687659937.stgit@warthog.procyon.org.uk> <147933287290.19316.3360403691390019935.stgit@warthog.procyon.org.uk> From: Josh Boyer Date: Fri, 18 Nov 2016 06:58:30 -0500 X-Google-Sender-Auth: OOL0gFWQXNAD7tFXl6CChWKt9jQ Message-ID: Subject: Re: [PATCH 05/16] efi: Add EFI_SECURE_BOOT bit To: Ard Biesheuvel Cc: David Howells , keyrings@vger.kernel.org, Matthew Garrett , "linux-efi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , linux-security-module Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1274 Lines: 36 On Thu, Nov 17, 2016 at 4:58 PM, Ard Biesheuvel wrote: > On 16 November 2016 at 21:47, David Howells wrote: >> From: Josh Boyer >> >> UEFI machines can be booted in Secure Boot mode. Add a EFI_SECURE_BOOT bit >> for use with efi_enabled. >> >> Signed-off-by: Josh Boyer >> Signed-off-by: David Howells >> --- >> >> arch/x86/kernel/setup.c | 1 + >> include/linux/efi.h | 1 + >> 2 files changed, 2 insertions(+) >> >> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c >> index 9521acce8378..539f29587712 100644 >> --- a/arch/x86/kernel/setup.c >> +++ b/arch/x86/kernel/setup.c >> @@ -1164,6 +1164,7 @@ void __init setup_arch(char **cmdline_p) >> if (boot_params.secure_boot && >> IS_ENABLED(CONFIG_EFI_SECURE_BOOT_LOCK_DOWN)) { >> lock_kernel_down(); >> + set_bit(EFI_SECURE_BOOT, &efi.flags); > > Why is this x86 only? And why is this bit only set if Because it was initially written like 3 years ago before ARM even had UEFI. Needs a refresh. > CONFIG_EFI_SECURE_BOOT_LOCK_DOWN is enabled? That part is new and something David added. Probably not necessary. josh