Message-ID: <1479470509.2563.3.camel@redhat.com>
Subject: Re: [PATCH 1/4] statx: Add a system call to make enhanced file info
 available
From: Jeff Layton <jlayton@redhat.com>
To: David Howells <dhowells@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Fri, 18 Nov 2016 07:01:49 -0500
In-Reply-To: <25389.1479458901@warthog.procyon.org.uk>
References: <1479407964.4556.5.camel@redhat.com>
         <147938969703.13574.10295364502230379833.stgit@warthog.procyon.org.uk>
         <147938970382.13574.11581172952175034619.stgit@warthog.procyon.org.uk>
         <25389.1479458901@warthog.procyon.org.uk>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 826
Lines: 29

On Fri, 2016-11-18 at 08:48 +0000, David Howells wrote:
> Jeff Layton <jlayton@redhat.com> wrote:
> 
> > 
> > > 
> > > If neither AT_STATX_*_SYNC flag is set, the behaviour is the default for
> > > stat() on that filesystem.
> > > 
> > 
> > We also need to specify here what happens if both bits are set. Should
> > that be -EINVAL?
> 
> Makes sense.
> 
> This leads to another thought: should fstatat() be allowed to take AT_STATX_*
> flags?
> 
> David

In principle, we could. fstatat currently rejects flags that it doesn't
understand with -EINVAL.

That said, I'd vote no -- if you wanted to change an application to
start setting these flags in fstatat calls, then it's just as simple to
convert it over to use statx. I don't see a lot of benefit in adding
that to a legacy syscall.

-- 
Jeff Layton <jlayton@redhat.com>