Subject: Re: [PATCH] ARM: dts: qcom: Add apq8064 CoreSight components
To: Stephen Boyd <sboyd@codeaurora.org>, andy.gross@linaro.org
References: <20161117153609.11705-1-georgi.djakov@linaro.org>
 <d466f591-baac-c734-a49b-8aab763c1876@codeaurora.org>
Cc: robh+dt@kernel.org, devicetree@vger.kernel.org,
        mathieu.poirier@linaro.org, zhang.chunyan@linaro.org,
        iivanov.xz@gmail.com, linux-arm-msm@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
From: Georgi Djakov <georgi.djakov@linaro.org>
Message-ID: <fda017e4-2902-359e-dad4-b0efd9ebeeb9@linaro.org>
Date: Fri, 18 Nov 2016 14:36:44 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <d466f591-baac-c734-a49b-8aab763c1876@codeaurora.org>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 997
Lines: 24

On 11/18/2016 12:16 AM, Stephen Boyd wrote:
> On 11/17/2016 07:36 AM, Georgi Djakov wrote:
>> From: "Ivan T. Ivanov" <ivan.ivanov@linaro.org>
>>
>> Add initial set of CoreSight components found on Qualcomm's
>> 8064 chipset.
>>
>> Signed-off-by: Ivan T. Ivanov <ivan.ivanov@linaro.org>
>> Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
>> ---
>>  arch/arm/boot/dts/qcom-apq8064-coresight.dtsi | 196 ++++++++++++++++++++++++++
>
> Why not put this inside the soc file? This would be the first time we
> add a new file for something that's inside the SoC node that probably
> won't change thereafter. At least for pins I slightly agree with having
> a different file, we're adding more and more things there so it's nice
> to have a consolidated place of all possible configurations to choose
> from. But here it's mostly a static device description so what's the gain?

Ok, after thinking more about this and looking at other soc dtsi files i 
agree with you. Will update!

Thanks!
Georgi