From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: Luis Henriques <henrix@camandro.org>
Cc: Arnd Bergmann <arnd@arndb.de>, Ben Dooks <ben.dooks@codethink.co.uk>,
        Evan Wang <xswang@marvell.com>, Marcin Wojtas <mw@semihalf.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bus: mvebu-mbus: fix iounmap() in error path
References: <20161116225445.30771-1-henrix@camandro.org>
Date: Fri, 18 Nov 2016 13:48:39 +0100
In-Reply-To: <20161116225445.30771-1-henrix@camandro.org> (Luis Henriques's
        message of "Wed, 16 Nov 2016 22:54:45 +0000")
Message-ID: <87twb59cns.fsf@free-electrons.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1340
Lines: 47

Hi Luis,
 
 On mer., nov. 16 2016, Luis Henriques <henrix@camandro.org> wrote:

> This patch fixes the following Coccinelle error:
>
> ./drivers/bus/mvebu-mbus.c:1115:2-8: \
> 	ERROR: missing iounmap; ioremap on line 1108 \
> 	and execution via conditional on line 1113
>
> Although all mvebu_mbus_common_init() callers seem to actually use
> &mbus_state in the 1st argument, this is still a bug that could be
> triggered by future changes.
>
> Signed-off-by: Luis Henriques <henrix@camandro.org>

Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>

and applied on mvebu/dt

Thanks,

Gregory

> ---
>  drivers/bus/mvebu-mbus.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bus/mvebu-mbus.c b/drivers/bus/mvebu-mbus.c
> index c7f396903184..449466eff56f 100644
> --- a/drivers/bus/mvebu-mbus.c
> +++ b/drivers/bus/mvebu-mbus.c
> @@ -1111,7 +1111,7 @@ static int __init mvebu_mbus_common_init(struct mvebu_mbus_state *mbus,
>  
>  	mbus->sdramwins_base = ioremap(sdramwins_phys_base, sdramwins_size);
>  	if (!mbus->sdramwins_base) {
> -		iounmap(mbus_state.mbuswins_base);
> +		iounmap(mbus->mbuswins_base);
>  		return -ENOMEM;
>  	}
>  

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com