From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Russell King - ARM Linux <linux@armlinux.org.uk>,
        Andrew Lunn <andrew@lunn.ch>, Heiko Stuebner <heiko@sntech.de>,
        geert+renesas@glider.be, Linus Walleij <linus.walleij@linaro.org>,
        Liviu Dudau <liviu.dudau@arm.com>,
        Patrice Chotard <patrice.chotard@st.com>,
        Wei Xu <xuwei5@hisilicon.com>, Jisheng Zhang <jszhang@marvell.com>,
        "pankaj.dubey" <pankaj.dubey@samsung.com>, magnus.damm@gmail.com,
        Michal Simek <michal.simek@xilinx.com>, krzk@kernel.org,
        thomas.ab@samsung.com, "cpgs ." <cpgs@samsung.com>,
        Stephen Warren <swarren@wwwdotorg.org>, Ray Jui <rjui@broadcom.com>,
        horms@verge.net.au, Jun Nie <jun.nie@linaro.org>,
        shiraz.linux.kernel@gmail.com, linux-kernel@vger.kernel.org,
        vireshk@kernel.org, Dinh Nguyen <dinguyen@opensource.altera.com>,
        Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH 01/16] ARM: scu: Provide support for parsing SCU device node to enable SCU
Date: Fri, 18 Nov 2016 14:32:30 +0100
Message-ID: <2339821.zs8sl71mMv@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <20161118124805.GJ1041@n2100.armlinux.org.uk>
References: <1479099731-28108-1-git-send-email-pankaj.dubey@samsung.com> <9481995.AMBiYg893F@wuerfel> <20161118124805.GJ1041@n2100.armlinux.org.uk>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1475
Lines: 43

On Friday, November 18, 2016 12:48:07 PM CET Russell King - ARM Linux wrote:
> On Fri, Nov 18, 2016 at 01:14:35PM +0100, Arnd Bergmann wrote:
> > @@ -41,6 +43,9 @@ void scu_enable(void __iomem *scu_base)
> >  {
> >       u32 scu_ctrl;
> >  
> > +     if (scu_base)
> > +             scu_base = scu_base_addr;
> > +
> 
> This looks to me like nonsense.
> 
> >  #ifdef CONFIG_ARM_ERRATA_764369
> >       /* Cortex-A9 only */
> >       if ((read_cpuid_id() & 0xff0ffff0) == 0x410fc090) {
> > @@ -85,6 +90,9 @@ int scu_power_mode(void __iomem *scu_base, unsigned int mode)
> >       unsigned int val;
> >       int cpu = MPIDR_AFFINITY_LEVEL(cpu_logical_map(smp_processor_id()), 0);
> >  
> > +     if (scu_base)
> > +             scu_base = scu_base_addr;
> > +
> 
> Ditto.
> 
> Rather than doing this, I'd much prefer to always store the SCU base in
> the SCU code, and remove the "void __iomem *scu_base" argment from all
> these functions.

Ok, then we just need one scu_probe_*() variant for each of the
four methods of initializing it (iotable, of_iomap,
ioremap(scu_a9_get_base) and hardcoded.

The intention of doing the fallback for the NULL argument was
to avoid having to add lots of new API while also allowing
the change to be done one platform at a time.

If we remove the argument from the other functions, they either
need to get a new name, or we change them all to the new prototype
at once. Either way works fine, do you have a preference between
them?

	Arnd