Date: Fri, 18 Nov 2016 15:15:40 +0100
From: Johan Hovold <johan@kernel.org>
To: Rahul Krishnan <mrahul.krishnan@gmail.com>
Cc: rmfrfs@gmail.com, elder@kernel.org, johan@kernel.org,
        gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2]: staging: Greybus: Remove unnecessary braces for
 single statement block
Message-ID: <20161118141540.GH10490@localhost>
References: <20161118133419.GA4346@rahul>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20161118133419.GA4346@rahul>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1019
Lines: 31

On Fri, Nov 18, 2016 at 07:04:20PM +0530, Rahul Krishnan wrote:
> This patch fixes the following checkpath.pl warning
> WARNING: braces {} are not necessary for single statement blocks
> 
> Fixed indentation error, noted by Dan Carpenter
> 
> Signed-off-by: Rahul Krishnan <mrahul.krishnan@gmail.com>
> ---
>  drivers/staging/greybus/sdio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/greybus/sdio.c b/drivers/staging/greybus/sdio.c
> index f60b458..66b37ea 100644
> --- a/drivers/staging/greybus/sdio.c
> +++ b/drivers/staging/greybus/sdio.c
> @@ -192,7 +192,7 @@ static int _gb_sdio_process_events(struct gb_sdio_host *host, u8 event)
>  	}
>  
>  	if (event & GB_SDIO_WP)
> -	host->read_only = true;
> +		host->read_only = true;

You need to redo your original patch. This one instead looks like a
follow-up to your first revision (which actually removed the braces).

>  
>  	if (state_changed) {
>  		dev_info(mmc_dev(host->mmc), "card %s now event\n",

Thanks,
Johan