Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752806AbcKROpg (ORCPT ); Fri, 18 Nov 2016 09:45:36 -0500 Received: from mga04.intel.com ([192.55.52.120]:48482 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753560AbcKROpS (ORCPT ); Fri, 18 Nov 2016 09:45:18 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,510,1473145200"; d="scan'208";a="1061162712" From: Alexander Shishkin To: Chunyan Zhang , rostedt@goodmis.org, mathieu.poirier@linaro.org, mingo@redhat.com Cc: mike.leach@arm.com, tor@ti.com, philippe.langlais@st.com, nicolas.guion@st.com, felipe.balbi@linux.intel.com, zhang.lyra@gmail.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH V8 3/3] stm: Mark the functions of writing buffer with notrace In-Reply-To: <1479438454-28650-4-git-send-email-zhang.chunyan@linaro.org> References: <1479438454-28650-1-git-send-email-zhang.chunyan@linaro.org> <1479438454-28650-4-git-send-email-zhang.chunyan@linaro.org> User-Agent: Notmuch/0.22.1 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Fri, 18 Nov 2016 16:45:13 +0200 Message-ID: <871sy8g83q.fsf@ashishki-desk.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1062 Lines: 27 Chunyan Zhang writes: > If CONFIG_STM_SOURCE_FTRACE is selected, Function trace data can be writen > to sink via STM, all functions that related to writing data packets to > STM should be marked 'notrace' to avoid being traced by Ftrace, otherwise > the program would stall into an endless loop. > > Signed-off-by: Chunyan Zhang > Acked-by: Steven Rostedt > --- > drivers/hwtracing/coresight/coresight-stm.c | 2 +- > drivers/hwtracing/intel_th/sth.c | 11 +++++++---- > drivers/hwtracing/stm/core.c | 7 ++++--- > drivers/hwtracing/stm/dummy_stm.c | 2 +- > include/linux/stm.h | 4 ++-- > 5 files changed, 15 insertions(+), 11 deletions(-) Quick nit: can you please split this one in 4: one for Coresight, one for Intel TH, one for stm/dummy and one for stm/core? I'd like to keep the bisectability. Otherwise, this is fine by me: Acked-by: Alexander Shishkin Regards, -- Alex