Date: Fri, 18 Nov 2016 09:53:07 -0500
From: Steven Rostedt <rostedt@goodmis.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "T.Zhou" <t1zhou@163.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched/rt: Change rt_nr_running to rt_queued in the
 comment
Message-ID: <20161118095307.799fbac8@gandalf.local.home>
In-Reply-To: <20161118063904.GA5376@geo>
References: <20161118063904.GA5376@geo>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 920
Lines: 35


Peter,

Can you pull this patch into your queue?

Acked-by: Steven Rostedt <rostedt@goodmis.org>

-- Steve


On Fri, 18 Nov 2016 14:39:04 +0800
"T.Zhou" <t1zhou@163.com> wrote:

> The code actually checks rt_queued not rt_nr_running
> in pick_next_task_rt(), so change the corresponding
> comment.
> 
> Signed-off-by: T.Zhou <t1zhou@163.com>
> ---
>  kernel/sched/rt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
> index 2516b8d..9b4a5c5 100644
> --- a/kernel/sched/rt.c
> +++ b/kernel/sched/rt.c
> @@ -1550,7 +1550,7 @@ pick_next_task_rt(struct rq *rq, struct task_struct *prev, struct pin_cookie coo
>  
>  	/*
>  	 * We may dequeue prev's rt_rq in put_prev_task().
> -	 * So, we update time before rt_nr_running check.
> +	 * So, we update time before rt_queued check.
>  	 */
>  	if (prev->sched_class == &rt_sched_class)
>  		update_curr_rt(rq);