Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753261AbcKRPap (ORCPT ); Fri, 18 Nov 2016 10:30:45 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:36611 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752824AbcKRPao (ORCPT ); Fri, 18 Nov 2016 10:30:44 -0500 Date: Fri, 18 Nov 2016 15:30:40 +0000 From: Rui Miguel Silva To: Rahul Krishnan Cc: elder@kernel.org, johan@kernel.org, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH]: staging: Greybus: Remove unnecessary braces for single statement block Message-ID: <20161118153040.GA9364@arch-late.localdomain> References: <20161118151525.GA6732@rahul> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20161118151525.GA6732@rahul> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 938 Lines: 35 Hi Rahul, Thanks for the patch. Now looks great. On Fri, Nov 18, 2016 at 08:45:25PM +0530, Rahul Krishnan wrote: >This patch fixes the following checkpath.pl warning >WARNING: braces {} are not necessary for single statement blocks > > >Signed-off-by: Rahul Krishnan Reviewed-by: Rui Miguel Silva >--- > drivers/staging/greybus/sdio.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >diff --git a/drivers/staging/greybus/sdio.c b/drivers/staging/greybus/sdio.c >index 5649ef1..66b37ea 100644 >--- a/drivers/staging/greybus/sdio.c >+++ b/drivers/staging/greybus/sdio.c >@@ -191,9 +191,8 @@ static int _gb_sdio_process_events(struct gb_sdio_host *host, u8 event) > state_changed = 1; > } > >- if (event & GB_SDIO_WP) { >+ if (event & GB_SDIO_WP) > host->read_only = true; >- } > > if (state_changed) { > dev_info(mmc_dev(host->mmc), "card %s now event\n", >-- >2.10.2 >