Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262479AbTEILbi (ORCPT ); Fri, 9 May 2003 07:31:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262482AbTEILbh (ORCPT ); Fri, 9 May 2003 07:31:37 -0400 Received: from gate.perex.cz ([194.212.165.105]:34053 "EHLO gate.perex.cz") by vger.kernel.org with ESMTP id S262479AbTEILb3 (ORCPT ); Fri, 9 May 2003 07:31:29 -0400 Date: Fri, 9 May 2003 13:43:20 +0200 (CEST) From: Jaroslav Kysela X-X-Sender: perex@pnote.perex-int.cz To: Christoph Hellwig Cc: "viro@parcelfarce.linux.theplanet.co.uk" , "torvalds@transmeta.com" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] remove unused funcion proc_mknod In-Reply-To: <20030505213004.B24006@lst.de> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1529 Lines: 39 On Mon, 5 May 2003, Christoph Hellwig wrote: > On Mon, May 05, 2003 at 08:22:48PM +0100, viro@parcelfarce.linux.theplanet.co.uk wrote: > > manually. IOW, removal of proc_mknod() won't solve anything. The > > real question is whether we should allow device nodes on procfs. > > If we should not allow them, ALSA needs API changes. If we should, > > it'd be better to have creation of such nodes explicit (and if ALSA > > keeps doing that, it should switch to calling proc_mknod()). > > We shouldn't. It's very bad style. And it seems ALSA also registers a > chardev and devfs entries for that stuff. > > Jaroslav, can we just drop that junk or is it still used by userland. > And if yes how long will it take to get an alsa-libs release out to > not rely on it? alsa-lib doesn't rely on it at all. The devices in /dev/snd/ might be created in these ways: 1) static - using the mknod command 2) using devfs 3) link /dev/snd to /proc/asound/dev We prefered the third solution because we were changing heavily the device minor numbers in the past. We can remove the proc dynamic device creating from our code now. I agree, this code should not be in the kernel tree. Jaroslav ----- Jaroslav Kysela Linux Kernel Sound Maintainer ALSA Project, SuSE Labs - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/