Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754006AbcKRQtz (ORCPT ); Fri, 18 Nov 2016 11:49:55 -0500 Received: from mail-cys01nam02on0114.outbound.protection.outlook.com ([104.47.37.114]:40088 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753271AbcKRQtx (ORCPT ); Fri, 18 Nov 2016 11:49:53 -0500 From: Matthew Wilcox To: Konstantin Khlebnikov , Matthew Wilcox CC: Linux Kernel Mailing List , Andrew Morton , Ross Zwisler , linux-fsdevel , "linux-mm@kvack.org" , "Kirill A . Shutemov" Subject: RE: [PATCH 21/29] radix-tree: Delete radix_tree_locate_item() Thread-Topic: [PATCH 21/29] radix-tree: Delete radix_tree_locate_item() Thread-Index: AQHSQFgldFTzJ9IAW0SmZxbIp0wO2aDeo1oAgABOmwA= Date: Fri, 18 Nov 2016 16:34:05 +0000 Message-ID: References: <1479341856-30320-1-git-send-email-mawilcox@linuxonhyperv.com> <1479341856-30320-60-git-send-email-mawilcox@linuxonhyperv.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=mawilcox@microsoft.com; x-originating-ip: [184.175.4.94] x-ms-office365-filtering-correlation-id: 7f0d58af-ef3f-4a37-f725-08d40fd0b6d6 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:SN1PR21MB0080; x-microsoft-exchange-diagnostics: 1;SN1PR21MB0080;7:GhmD4b97r8n5HhSWBK7A/6rYPPCpAcawgxOHaNecIzxrcPMQoH9DShGmmoua9Yl781wdUlYKc5E0+uoKPm4bqvXbgX5v5aeFGbzppvUok5pQQFof+KAvInyQlMfw3LyC8OnHbsIleqnwAz1S3sx0SbM7GaEA+SUV0uIFWuOu4whM74pWi/VkRyP6pz/ViIPSzqr9VripG5P6lh5v82yaY03zoF22J3kQEXF5uYkhXewvxKcJW6SZUw90ipY8VbsiHpcXI9zZ6fZORhqoRtFxw8yGmupIa3l4uTknDyehBMQ6GmLQF2OOkTtnnmuN0qMI+iW3sShlp7tZ4f11z+25ylSguYzuU3ZrbIwyedbuu/QQuWzKxXOeYA2bUTGlNKeGYAIAqcW3rjQMFUU5bi92G5U/U7D5qmNsKBdlXzS0MBn9mNc6LbXXbqZ1XD1JxLZl7iYPOzplnx82rTFgiB8hdMyqGaU5TqVblpFjtbYCyrA= x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(61425038)(6040281)(6060326)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026)(61426038)(61427038)(6041223)(6061324);SRVR:SN1PR21MB0080;BCL:0;PCL:0;RULEID:;SRVR:SN1PR21MB0080; x-forefront-prvs: 01304918F3 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(7916002)(189002)(24454002)(377454003)(199003)(81166006)(76576001)(122556002)(87936001)(33656002)(81156014)(101416001)(54356999)(86362001)(68736007)(9686002)(8936002)(3660700001)(3280700002)(5660300001)(86612001)(2950100002)(7696004)(4326007)(2906002)(50986999)(77096005)(105586002)(6506003)(106116001)(92566002)(229853002)(305945005)(102836003)(97736004)(7736002)(189998001)(3846002)(74316002)(5001770100001)(76176999)(6116002)(7846002)(106356001)(99286002)(66066001)(10090500001)(8990500004)(5005710100001)(2900100001)(8676002)(10290500002)(38730400001);DIR:OUT;SFP:1102;SCL:1;SRVR:SN1PR21MB0080;H:SN1PR21MB0077.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Nov 2016 16:34:05.8786 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR21MB0080 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id uAIGnwSY020103 Content-Length: 614 Lines: 12 From: Konstantin Khlebnikov [mailto:koct9i@gmail.com] > On Thu, Nov 17, 2016 at 3:17 AM, Matthew Wilcox > wrote: > > This rather complicated function can be better implemented as an iterator. > > It has only one caller, so move the functionality to the only place that > > needs it. Update the test suite to follow the same pattern. > > Looks good. I suppose this patch could be applied separately. Yes, a number of these patches stand alone from each other and could easily be separated out. I'm going to put your Reviewed-by: on the patches you've said "Looks good" to. Thanks!