Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754171AbcKRRCB (ORCPT ); Fri, 18 Nov 2016 12:02:01 -0500 Received: from mail-oi0-f67.google.com ([209.85.218.67]:33876 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752526AbcKRRB5 (ORCPT ); Fri, 18 Nov 2016 12:01:57 -0500 Date: Fri, 18 Nov 2016 11:01:55 -0600 From: Rob Herring To: Andy Shevchenko Cc: Luis Oliveira , wsa@the-dreams.de, mark.rutland@arm.com, jarkko.nikula@linux.intel.com, mika.westerberg@linux.intel.com, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Ramiro.Oliveira@synopsys.com, Joao.Pinto@synopsys.com, CARLOS.PALMINHA@synopsys.com Subject: Re: [PATCH v3 3/5] i2c: designware: Add slave definitions Message-ID: <20161118170155.chrdpguohgl6vo5f@rob-hp-laptop> References: <1479472552.22212.23.camel@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1479472552.22212.23.camel@linux.intel.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1505 Lines: 49 On Fri, Nov 18, 2016 at 02:35:52PM +0200, Andy Shevchenko wrote: > On Fri, 2016-11-18 at 11:19 +0000, Luis Oliveira wrote: > > ?- Add slave defintitions to i2c-designware-core > > ?- Changes in Kconfig to auto-enable I2C_SLAVE when compiling the > > modules > > ?- Add compatible string to designware-core.txt explaining the > > devicetree bindings > > > > > > --- a/Documentation/devicetree/bindings/i2c/i2c-designware.txt > > +++ b/Documentation/devicetree/bindings/i2c/i2c-designware.txt > > @@ -2,7 +2,9 @@ > > ? > > ?Required properties : > > ? > > - - compatible : should be "snps,designware-i2c" > > + - compatible : should be: > > +???- "snps,designware-i2c" to setup the hardware block as I2C master. > > +???- "snps,designware-i2c-slave" to setup the hardware block as I2C > > slave. > > Not sure about this one. > > Compatible string is more generic than list of modes. Basically you have > to add a property which selects mode. Yes, agreed. And come up with a common property. > DT people's ACK is a must for this change. > > > --- a/drivers/i2c/busses/Kconfig > > +++ b/drivers/i2c/busses/Kconfig > > @@ -470,6 +470,7 @@ config I2C_DESIGNWARE_CORE > > ?config I2C_DESIGNWARE_PLATFORM > > ? tristate "Synopsys DesignWare Platform" > > ? select I2C_DESIGNWARE_CORE > > + select I2C_SLAVE > > > > Common rule, generic dependencies usually go first > > select I2C_SLAVE > ? select I2C_DESIGNWARE_CORE > > -- > Andy Shevchenko > Intel Finland Oy