Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753387AbcKRR2J (ORCPT ); Fri, 18 Nov 2016 12:28:09 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50334 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752699AbcKRR2E (ORCPT ); Fri, 18 Nov 2016 12:28:04 -0500 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <147933283664.19316.12454053022687659937.stgit@warthog.procyon.org.uk> <147933287290.19316.3360403691390019935.stgit@warthog.procyon.org.uk> To: Ard Biesheuvel Cc: dhowells@redhat.com, keyrings@vger.kernel.org, matthew.garrett@nebula.com, "linux-efi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , linux-security-module@vger.kernel.org, Josh Boyer Subject: Re: [PATCH 05/16] efi: Add EFI_SECURE_BOOT bit MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <6527.1479490081.1@warthog.procyon.org.uk> Date: Fri, 18 Nov 2016 17:28:01 +0000 Message-ID: <6528.1479490081@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Fri, 18 Nov 2016 17:28:04 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 621 Lines: 19 Ard Biesheuvel wrote: > > @@ -1164,6 +1164,7 @@ void __init setup_arch(char **cmdline_p) > > if (boot_params.secure_boot && > > IS_ENABLED(CONFIG_EFI_SECURE_BOOT_LOCK_DOWN)) { > > lock_kernel_down(); > > + set_bit(EFI_SECURE_BOOT, &efi.flags); > > Why is this x86 only? It probably doesn't really need to be, but that's what the patches I ported do. > And why is this bit only set if CONFIG_EFI_SECURE_BOOT_LOCK_DOWN is enabled? Actually, the EFI_SECURE_BOOT bit should probably be set outside of that portion of the if-condition. David