Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752952AbcKRSUz (ORCPT ); Fri, 18 Nov 2016 13:20:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53332 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751243AbcKRSUx (ORCPT ); Fri, 18 Nov 2016 13:20:53 -0500 Subject: Re: [PATCH] kvm: x86: merge kvm_arch_set_irq and kvm_arch_set_irq_inatomic To: Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org References: <1479394547-15249-3-git-send-email-pbonzini@redhat.com> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: <4d1b0863-8c51-079a-b74e-8950c51060ff@redhat.com> Date: Fri, 18 Nov 2016 19:20:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1479394547-15249-3-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 18 Nov 2016 18:20:53 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 572 Lines: 20 Am 17.11.2016 um 15:55 schrieb Paolo Bonzini: > kvm_arch_set_irq is unused since commit b97e6de9c96. Merge > its functionality with kvm_arch_set_irq_inatomic. > > Reported-by: Jiang Biao > Signed-off-by: Paolo Bonzini > --- As you said, it is unused. Therefore the functionality is superfluous. Why merge it? We can still introduce this later if we ever need it. Or do you have a concrete user in mind? The patch in general looks good to me. Just wondering if we can't simply rip out that single function. -- David