Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754142AbcKRS53 (ORCPT ); Fri, 18 Nov 2016 13:57:29 -0500 Received: from mail.kernel.org ([198.145.29.136]:60502 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752389AbcKRS5V (ORCPT ); Fri, 18 Nov 2016 13:57:21 -0500 MIME-Version: 1.0 In-Reply-To: <20161118141547.465c431e@lxorguk.ukuu.org.uk> References: <1479287278-5192-1-git-send-email-hean.loong.ong@intel.com> <20161118140903.q33zx7bk5nergq45@rob-hp-laptop> <20161118141547.465c431e@lxorguk.ukuu.org.uk> From: Rob Herring Date: Fri, 18 Nov 2016 12:56:55 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCHv0 1/1] fbdev: add Intel FPGA FRAME BUFFER driver To: One Thousand Gnomes Cc: "Ong, Hean Loong" , Tomi Valkeinen , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-fbdev@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 823 Lines: 22 On Fri, Nov 18, 2016 at 8:15 AM, One Thousand Gnomes wrote: >> AIUI, we're not taking new FB drivers. This should be a DRM driver >> instead. > > Yes - clone one of the dumb DRM drivers, or if you've got any little bits > of acceleration (even rolling the display) then it's possibly worth > accelerating for text mode. > >> > +- max-width: The width of the framebuffer in pixels. >> > +- max-height: The height of the framebuffer in pixels. >> > +- bits-per-color: only "8" is currently supported >> >> These are not h/w properties. > > How are the max ones not hardware properties ? Because the way they are used is setting the mode, not some check of the max when the mode is set. If this is synthesized for only one size, then that would be different, but we have bindings for modes. Rob