Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754213AbcKRT2l (ORCPT ); Fri, 18 Nov 2016 14:28:41 -0500 Received: from mga11.intel.com ([192.55.52.93]:27402 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752528AbcKRT2j (ORCPT ); Fri, 18 Nov 2016 14:28:39 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,659,1473145200"; d="scan'208";a="193121365" Message-ID: <1479497224.22212.42.camel@linux.intel.com> Subject: Re: [PATCH v3 1/2] DW DMAC: enable memory-to-memory transfers support From: Andy Shevchenko To: Eugeniy Paltsev , devicetree@vger.kernel.org Cc: robh+dt@kernel.org, mark.rutland@arm.com, linux-kernel@vger.kernel.org, vinod.koul@intel.com, dmaengine@vger.kernel.org, linux-snps-arc@lists.infradead.org Date: Fri, 18 Nov 2016 21:27:04 +0200 In-Reply-To: <1479496356-27834-2-git-send-email-Eugeniy.Paltsev@synopsys.com> References: <1479496356-27834-1-git-send-email-Eugeniy.Paltsev@synopsys.com> <1479496356-27834-2-git-send-email-Eugeniy.Paltsev@synopsys.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.2-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1099 Lines: 34 On Fri, 2016-11-18 at 22:12 +0300, Eugeniy Paltsev wrote: > All known devices, which use DT for configuration, support > memory-to-memory transfers. So enable it by default, if we read > configuration from DT. > > Signed-off-by: Eugeniy Paltsev You missed the given tag(s). > --- >  drivers/dma/dw/platform.c | 6 ++++++ >  1 file changed, 6 insertions(+) > > diff --git a/drivers/dma/dw/platform.c b/drivers/dma/dw/platform.c > index 5bda0eb..aa7a5c1 100644 > --- a/drivers/dma/dw/platform.c > +++ b/drivers/dma/dw/platform.c > @@ -129,6 +129,12 @@ dw_dma_parse_dt(struct platform_device *pdev) >   if (of_property_read_bool(np, "is_private")) >   pdata->is_private = true; >   > + /* > +  * All known devices, which use DT for configuration, support > +  * memory-to-memory transfers. So enable it by default. > +  */ > + pdata->is_memcpy = true; > + >   if (!of_property_read_u32(np, "chan_allocation_order", &tmp)) >   pdata->chan_allocation_order = (unsigned char)tmp; >   -- Andy Shevchenko Intel Finland Oy