Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754331AbcKRT3q (ORCPT ); Fri, 18 Nov 2016 14:29:46 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:40240 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754288AbcKRT3o (ORCPT ); Fri, 18 Nov 2016 14:29:44 -0500 Date: Fri, 18 Nov 2016 14:29:42 -0500 (EST) Message-Id: <20161118.142942.620136274318885678.davem@davemloft.net> To: tushar.n.dave@oracle.com Cc: sparclinux@vger.kernel.org, chris.hyser@oracle.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] sunqe: Fix compiler warnings From: David Miller In-Reply-To: <1476737820-29584-2-git-send-email-tushar.n.dave@oracle.com> References: <1476737820-29584-1-git-send-email-tushar.n.dave@oracle.com> <1476737820-29584-2-git-send-email-tushar.n.dave@oracle.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-7 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 18 Nov 2016 10:30:16 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id uAIJTnXa021293 Content-Length: 1168 Lines: 23 From: Tushar Dave Date: Mon, 17 Oct 2016 13:56:59 -0700 > sunqe uses '__u32' for dma handle while invoking kernel DMA APIs, > instead of using dma_addr_t. This hasn't caused any 'incompatible > pointer type' warning on SPARC because until now dma_addr_t is of > type u32. However, recent changes in SPARC ATU (iommu) enables 64bit > DMA and therefore dma_addr_t becomes of type u64. This makes > 'incompatible pointer type' warnings inevitable. > > e.g. > drivers/net/ethernet/sun/sunqe.c: In function ?qec_ether_init?: > drivers/net/ethernet/sun/sunqe.c:883: warning: passing argument 3 of ?dma_alloc_coherent? from incompatible pointer type > ./include/linux/dma-mapping.h:445: note: expected ?dma_addr_t *? but argument is of type ?__u32 *? > drivers/net/ethernet/sun/sunqe.c:885: warning: passing argument 3 of ?dma_alloc_coherent? from incompatible pointer type > ./include/linux/dma-mapping.h:445: note: expected ?dma_addr_t *? but argument is of type ?__u32 *? > > This patch resolves above compiler warnings. > > Signed-off-by: Tushar Dave > Reviewed-by: chris hyser Aplpied.