Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932163AbcKRT35 (ORCPT <rfc822;w@1wt.eu>);
        Fri, 18 Nov 2016 14:29:57 -0500
Received: from shards.monkeyblade.net ([184.105.139.130]:40250 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754354AbcKRT3z (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 18 Nov 2016 14:29:55 -0500
Date: Fri, 18 Nov 2016 14:29:49 -0500 (EST)
Message-Id: <20161118.142949.2261138244816252418.davem@davemloft.net>
To: tushar.n.dave@oracle.com
Cc: sparclinux@vger.kernel.org, chris.hyser@oracle.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] sunbmac: Fix compiler warning
From: David Miller <davem@davemloft.net>
In-Reply-To: <1476737820-29584-3-git-send-email-tushar.n.dave@oracle.com>
References: <1476737820-29584-1-git-send-email-tushar.n.dave@oracle.com>
        <1476737820-29584-3-git-send-email-tushar.n.dave@oracle.com>
X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=iso-8859-7
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 18 Nov 2016 10:30:22 -0800 (PST)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id uAIJU4Gm021297
Content-Length: 953
Lines: 21

From: Tushar Dave <tushar.n.dave@oracle.com>
Date: Mon, 17 Oct 2016 13:57:00 -0700

> sunbmac uses '__u32' for dma handle while invoking kernel DMA APIs,
> instead of using dma_addr_t. This hasn't caused any 'incompatible
> pointer type' warning on SPARC because until now dma_addr_t is of
> type u32. However, recent changes in SPARC ATU (iommu) enables 64bit
> DMA and therefore dma_addr_t becomes of type u64. This makes
> 'incompatible pointer type' warnings inevitable.
> 
> e.g.
> drivers/net/ethernet/sun/sunbmac.c: In function ?bigmac_ether_init?:
> drivers/net/ethernet/sun/sunbmac.c:1166: warning: passing argument 3 of ?dma_alloc_coherent? from incompatible pointer type
> ./include/linux/dma-mapping.h:445: note: expected ?dma_addr_t *? but argument is of type ?__u32 *?
> 
> This patch resolves above compiler warning.
> 
> Signed-off-by: Tushar Dave <tushar.n.dave@oracle.com>
> Reviewed-by: chris hyser <chris.hyser@oracle.com>

Applied.