Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
        Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
        Kingdom.
        Registered in England and Wales under Company Registration No. 3798903
From: David Howells <dhowells@redhat.com>
In-Reply-To: <20161118214106.GB31101@dastard>
References: <20161118214106.GB31101@dastard> <20161117234047.GE28177@dastard> <147938969703.13574.10295364502230379833.stgit@warthog.procyon.org.uk> <147938970382.13574.11581172952175034619.stgit@warthog.procyon.org.uk> <26219.1479462218@warthog.procyon.org.uk>
To: Dave Chinner <david@fromorbit.com>
Cc: dhowells@redhat.com, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <10741.1479507898.1@warthog.procyon.org.uk>
Date: Fri, 18 Nov 2016 22:24:58 +0000
Message-ID: <10742.1479507898@warthog.procyon.org.uk>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1284
Lines: 32

Dave Chinner <david@fromorbit.com> wrote:

> > Definition: "Same as struct stat::st_blksize".
> 
> So it is still defined as "mostly useless", then? :/

If we're going to be able to emulate stat() with this, then st_blksize must be
determinable from whatever's in struct statx.  If you can provide something
better for stx_blksize and an algorithm for mapping that to st_blksize, then
please do so.

> The test suite should be developed concurrently with the code. You
> know, best software engineering practices and all that. Just a small
> example: Darrick landed 100+ reflink related tests in xfstests
> before we merged the XFS reflink functionality.

I can't give you tests to merge yet.  Given the amount of bikeshedding that's
taken place on this, I'm glad I *haven't* done the testsuite yet - it would
have much more than doubled the amount of work.  I *still* don't know what the
final form is going to be.  I've chucked out almost everything extra because
every bit has someone who argues with it - and this includes people who argue
against things that have to be there!

Further:

	warthog>ls xfstests-dev/doc
	CHANGES

The documentation is missing.  There's a bit in the top level README, but
there's a whole lot of information that *should* be there - and isn't.

David