Date: Fri, 18 Nov 2016 14:27:12 -0800 (PST)
From: Hugh Dickins <hughd@google.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
cc: Hugh Dickins <hughd@google.com>,
        Mel Gorman <mgorman@techsingularity.net>, david.vrabel@citrix.com,
        jgross@suse.com, xen-devel@lists.xenproject.org,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org, olaf@aepfle.de
Subject: Re: [PATCH v3 (re-send)] xen/gntdev: Use mempolicy instead of VM_IO
 flag to avoid NUMA balancing
In-Reply-To: <2bf041f3-8918-3c6f-8afb-c9edcc03dcd9@oracle.com>
Message-ID: <alpine.LSU.2.11.1611181421470.10145@eggly.anvils>
References: <1479413404-27332-1-git-send-email-boris.ostrovsky@oracle.com> <alpine.LSU.2.11.1611181335560.9605@eggly.anvils> <2bf041f3-8918-3c6f-8afb-c9edcc03dcd9@oracle.com>
User-Agent: Alpine 2.11 (LSU 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 833
Lines: 18

On Fri, 18 Nov 2016, Boris Ostrovsky wrote:
> On 11/18/2016 04:51 PM, Hugh Dickins wrote:
> > Hmm, sorry, but this seems overcomplicated to me: ingenious, but an
> > unusual use of the ->get_policy method, which is a little worrying,
> > since it has only been used for shmem (+ shm and kernfs) until now.
> >
> > Maybe I'm wrong, but wouldn't substituting VM_MIXEDMAP for VM_IO
> > solve the problem more simply?
> 
> It would indeed. I didn't want to use it because it has specific meaning
> ("Can contain "struct page" and pure PFN pages") and that didn't seem
> like the right flag to describe this vma.

It is okay if it contains 0 pure PFN pages; and no worse than VM_IO was.
A comment on why VM_MIXEDMAP is being used there would certainly be good.
But I do find its use preferable to enlisting an unusual ->get_policy.

Hugh